EDCT error?

[Tollheit]

A question about export_descr_character_traits.txt, as of EB 1.1, including client ruler fix;
The following pararagraph,

;Mod: EBMod601 - 07/07 : new triggers to track cumulative victory/defeat rating
;------------------------------------------
Trigger EB_01_Win_Stops_Losing_Streak_a
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and Trait CumulativeBattleLosses > 0

  Affects CumulativeBattleWins  1  Chance  100

;------------------------------------------
Trigger EB_01_Win_Stops_Losing_Streak_b
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and Trait CumulativeBattleLosses > 0

  Affects CumulativeBattleWins  1  Chance  100

;------------------------------------------
Trigger EB_01_Win_Stops_Losing_Streak_c
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and Trait CumulativeBattleLosses > 0

  Affects CumulativeBattleWins  1  Chance  100

;------------------------------------------
Trigger EB_02_Win_Adds_to_Cumulative_Wins
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle

  Affects CumulativeBattleWins  1  Chance  100

;------------------------------------------
Trigger EB_03_Loss_Stops_Winning_Streak_a
  WhenToTest PostBattle

    Condition IsGeneral
          and not WonBattle
          and Trait CumulativeBattleWins > 0

  Affects CumulativeBattleLosses  1  Chance  100

;------------------------------------------
Trigger EB_03_Win_Stops_Losing_Streak_b
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and Trait CumulativeBattleWins > 0

  Affects CumulativeBattleLosses  1  Chance  100

;------------------------------------------
Trigger EB_03_Win_Stops_Losing_Streak_c
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and Trait CumulativeBattleWins > 0

  Affects CumulativeBattleLosses  1  Chance  100

;------------------------------------------
Trigger EB_04_Loss_Adds_to_Cumulative_Losses
  WhenToTest PostBattle

    Condition IsGeneral
          and not WonBattle

  Affects CumulativeBattleLosses  1  Chance  100

shouldn’t it read:

;Mod: EBMod601 - 07/07 : new triggers to track cumulative victory/defeat rating
;------------------------------------------
Trigger EB_01_Win_Stops_Losing_Streak_a
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and Trait CumulativeBattleLosses > 0

  Affects CumulativeBattleWins  1  Chance  100

;------------------------------------------
Trigger EB_01_Win_Stops_Losing_Streak_b
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and Trait CumulativeBattleLosses > 0

  Affects CumulativeBattleWins  1  Chance  100

;------------------------------------------
Trigger EB_01_Win_Stops_Losing_Streak_c
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and Trait CumulativeBattleLosses > 0

  Affects CumulativeBattleWins  1  Chance  100

;------------------------------------------
Trigger EB_02_Win_Adds_to_Cumulative_Wins
  WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle

  Affects CumulativeBattleWins  1  Chance  100

;------------------------------------------
Trigger EB_03_Loss_Stops_Winning_Streak_a
  WhenToTest PostBattle

    Condition IsGeneral
          and not WonBattle
          and Trait CumulativeBattleWins > 0

  Affects CumulativeBattleLosses  1  Chance  100

;------------------------------------------
Trigger EB_03_Loss_Stops_Winning_Streak_b
  WhenToTest PostBattle

    Condition IsGeneral
          and not WonBattle
          and Trait CumulativeBattleWins > 0

  Affects CumulativeBattleLosses  1  Chance  100

;------------------------------------------
Trigger EB_03_Loss_Stops_Winning_Streak_c
  WhenToTest PostBattle

    Condition IsGeneral
          and not WonBattle
          and Trait CumulativeBattleWins > 0

  Affects CumulativeBattleLosses  1  Chance  100

;------------------------------------------
Trigger EB_04_Loss_Adds_to_Cumulative_Losses
  WhenToTest PostBattle

    Condition IsGeneral
          and not WonBattle

  Affects CumulativeBattleLosses  1  Chance  100

My suggestions marked in red.
If I made some stupid mistake or unjustified assumption, please have mercy on me.

[bovi]

No, it seems you are right. I'm sure it was a copy-paste error. Fixed in a few minutes .

Edit: And done.

[Tollheit]

Thank you.
Another question about the same file, another paragraph:

;------------------------------------------
Trigger EB007_Standard_Battle_Attacker_Easy
  WhenToTest PostBattle

    Condition WasAttacker
          and IsGeneral
          and not BattleOdds < 1.5

  Affects RecentBattleDifficulty  1  Chance  100

;------------------------------------------
;Trigger EB007b_Siege_Battle_Attacker_Easy
;  WhenToTest PostBattle
;
;    Condition WasAttacker
;          and IsGeneral
;          and I_ConflictType Siege
;          and not BattleOdds < 0.66
;
;  Affects RecentBattleDifficulty  1  Chance  100
;
;Mod: EBMod472 - 05/11 : new trigger for easy odds
;------------------------------------------
Trigger EB008_Standard_Battle_Attacker_Medium
  WhenToTest PostBattle

    Condition WasAttacker
          and IsGeneral
          and BattleOdds < 1.5
          and not BattleOdds < 0.75

  Affects RecentBattleDifficulty  2  Chance  100
  Affects BattlePoints  4  Chance  100

;------------------------------------------
;Trigger EB008b_Siege_Battle_Attacker_Medium
;  WhenToTest PostBattle
;
;    Condition WasAttacker
;          and IsGeneral
;          and not I_ConflictType Siege
;          and BattleOdds < 1.5
;          and not BattleOdds < 0.75
;;
;  Affects RecentBattleDifficulty  2  Chance  100
;  Affects BattlePoints  4  Chance  100
;
;Mod: EBMod473 - 05/11 : new trigger for medium odds
;------------------------------------------
Trigger EB009_Standard_Battle_Attacker_Hard
  WhenToTest PostBattle

    Condition WasAttacker
          and IsGeneral
          and BattleOdds < 0.75
          and not BattleOdds < 0.2

  Affects RecentBattleDifficulty  3  Chance  100
  Affects BattlePoints  8  Chance  100

;Mod: EBMod474 - 05/11 : new trigger for hard odds
;------------------------------------------
Trigger EB010_Standard_Battle_Attacker_Very_Hard
  WhenToTest PostBattle

    Condition WasAttacker
          and IsGeneral
          and BattleOdds < 0.2

  Affects RecentBattleDifficulty  4  Chance  100
  Affects BattlePoints  12  Chance  100

;Mod: EBMod475 - 05/11 : new trigger for very hard odds
;------------------------------------------
Trigger EB032_Standard_Battle_Defender_Easy
  WhenToTest PostBattle

    Condition not WasAttacker
          and IsGeneral
          and not I_ConflictType Siege
          and not BattleOdds < 1.0

  Affects RecentBattleDifficulty  1  Chance  100

;------------------------------------------
Trigger EB032b_Siege_Battle_Defender_Easy
  WhenToTest PostBattle

    Condition not WasAttacker
          and IsGeneral
          and I_ConflictType Siege
          and not BattleOdds < 0.6

  Affects RecentBattleDifficulty  1  Chance  100

;Mod: EBMod499 - 05/12 : new trigger for easy odds
;------------------------------------------
Trigger EB033_Standard_Battle_Defender_Medium
  WhenToTest PostBattle

    Condition not WasAttacker
          and IsGeneral
          and not I_ConflictType Siege
          and BattleOdds < 1.0
          and not BattleOdds < 0.6

  Affects RecentBattleDifficulty  2  Chance  100
  Affects BattlePoints  4  Chance  100

;------------------------------------------
Trigger EB033b_Siege_Battle_Defender_Medium
  WhenToTest PostBattle

    Condition not WasAttacker
          and IsGeneral
          and I_ConflictType Siege
          and BattleOdds < 1.5
          and not BattleOdds < 0.6

  Affects RecentBattleDifficulty  2  Chance  100
  Affects BattlePoints  4  Chance  100

;Mod: EBMod500 - 05/12 : new trigger for medium odds
;------------------------------------------
Trigger EB034_Standard_Battle_Defender_Hard
  WhenToTest PostBattle

    Condition not WasAttacker
          and IsGeneral
          and not I_ConflictType Siege
          and BattleOdds < 0.6
          and not BattleOdds < 0.2

  Affects RecentBattleDifficulty  3  Chance  100
  Affects BattlePoints  8  Chance  100

;------------------------------------------
Trigger EB034b_Siege_Battle_Defender_Hard
  WhenToTest PostBattle

    Condition not WasAttacker
          and IsGeneral
          and I_ConflictType Siege
          and BattleOdds < 5.0
          and not BattleOdds < 1.5

  Affects RecentBattleDifficulty  3  Chance  100
  Affects BattlePoints  8  Chance  100


;Mod: EBMod501 - 05/12 : new trigger for hard odds
;------------------------------------------
Trigger EB035_Standard_Battle_Defender_Very_Hard
  WhenToTest PostBattle

    Condition not WasAttacker
          and IsGeneral
          and not I_ConflictType Siege
          and BattleOdds < 0.2

  Affects RecentBattleDifficulty  4  Chance  100
  Affects BattlePoints  12  Chance  100

;------------------------------------------
Trigger EB035b_Siege_Battle_Defender_Very_Hard
  WhenToTest PostBattle

    Condition not WasAttacker
          and IsGeneral
          and I_ConflictType Siege
          and BattleOdds > 5.0

  Affects RecentBattleDifficulty  4  Chance  100
  Affects BattlePoints  12  Chance  100

;Mod: EBMod502 - 05/12 : new trigger for very hard odds

So, as I understand it we have here BattleOdds conditions for:

Standart_battle_attacker
Easy: ≥1.5
Medium:0,75-1,5
Hard: 0,2 - 0,75
Very hard: < 0,2

Standart_battle_defender
Easy: ≥ 1.0
Medium: 1.0-0,6
Hard: 0,2-06
Very Hard: <0,2

Siege_battle_defender
Easy: ≥ 0,6
Medium: 0,6-1,5 inconsistent with Siege_battle_defender_easy*
Hard: 1,5-5,0 inconsistent with Siege_battle_defender_easy*
Very Hard: > 5.0 inconsistent with Siege_battle_defender_easy*

*Also I think high values for BattleOdds indicate easy battles

[BozosLiveHere]

Thanks.

[||Lz3||]

should I add this to my file? or there's no game-crashing stuff with it?

[bovi]

Triggers are safe to modify.