Redundant Triggers?

[BozosLiveHere]

I don´t know if this is the proper place to be asking this, but the recent fix to the reinforcement CTD bug made me take a look at EB´s traits file and I found a lot of identical, redundant triggers... Are there any reasons for their existence? I´m particularly puzzled by lines like these:

Trigger winter_calibration_turn_1139
WhenToTest CharacterTurnStart

Condition I_TurnNumber = 1139
and Trait Season < 4

Affects Season 1 Chance 100

;------------------------------------------
Trigger winter_calibration_again_turn_1139
WhenToTest CharacterTurnStart

Condition I_TurnNumber = 1139
and Trait Season < 4

Affects Season 1 Chance 100

;------------------------------------------
Trigger winter_calibration_final_turn_1139
WhenToTest CharacterTurnStart

Condition I_TurnNumber = 1139
and Trait Season < 4

Affects Season 1 Chance 100

The thing is that these final and again triggers only appear in relation to some turns. It just left me very curious, so if any of the traiters is willing to explain them, I´d appreciate.

[orwell]

Were those found in sequential order? or were there spaces between each? I know the team has mentioned that on the very low priority list is cleaning up the traits, scripts, and other files.

[BozosLiveHere]

Sequential. I started noticing them after I saw that the first PostBattle triggers were redundant (no_longer_bored3_postbattle and no_longer_bored3_postbattle2).

[Kull]

I know the team has mentioned that on the very low priority list is cleaning up the traits, scripts, and other files.

Cleaning up/fixing traits and scripts is currently THE top priority for the team. So please keep "pulling on these threads". I'll try and direct our scripter/traiter folks over here to answer questions, but keep looking for stuff that seems odd/doesn't make sense.

The current theory is that the reinforcement CTD might be caused when a post-battle trait triggers the award of a "problem" ancillary. You guys could help me out quite a bit by laying out that trail so we can see which ancillaries are affected (I already found one case of inconsistent code....there may be others).

The tool I use for this is called Inforapid Search & Replace. It's freeware, and allows you to look - for example - for every use of the word "Heroic" in every text file in every subdirectory of a given root directory. Very helpful for this kind of thing.

[BozosLiveHere]

I think I might be able to help with that. Although my level of expertise isn't enough to let me write new traits, I can understand pretty well what existing ones are trying to do. About the software, I'm using the fantastic UltraEdit-32, which is the closest thing to a perfect piece of software that I know.

[orwell]

I'll be sure to keep an eye out for this then, since I'm going through the script, traits, and ancillaries.


Cleaning up/fixing traits and scripts is currently THE top priority for the team. So please keep "pulling on these threads". I'll try and direct our scripter/traiter folks over here to answer questions, but keep looking for stuff that seems odd/doesn't make sense.

The current theory is that the reinforcement CTD might be caused when a post-battle trait triggers the award of a "problem" ancillary. You guys could help me out quite a bit by laying out that trail so we can see which ancillaries are affected (I already found one case of inconsistent code....there may be others).

The tool I use for this is called Inforapid Search & Replace. It's freeware, and allows you to look - for example - for every use of the word "Heroic" in every text file in every subdirectory of a given root directory. Very helpful for this kind of thing.

[Kull]

Thanks guys! :2thumbsup:

[BozosLiveHere]

Ok, I think I have some bad news. I took a first look at the 27 postbattle triggers that lead to ancillaries, and they seem to have well formed syntaxes. This is bad because 25 of these triggers have a less than 25% chance of activating their traits (exceptions are acquire_heroic_saviour with 50% and trigger_scout with 90%). Now, from my understanding, if these triggers are well formed and the chance of them activating their traits is small, then CTDs caused by an inconsistent trail (leading from trait triggers, to traits, to ancillary triggers, to ancillaries) wouldn't be persistent, i.e. you could probably just replay the battle and luckily avoid the CTD.

Anyway, I'll keep looking, but now I'm afraid we won't be able to dismiss the other 409 postbattle triggers that easily. :wall:

[therother]

I'd need to speak to Malrubius to be sure, but I seem to recall these triggers are there to ensure that the characters keep track of the seasons properly. There were some problems reported with the system initially.