Renforcment CTD

[Pharnakes]

What exactly was this, I never had it, but I think I might have managed to reactivate it, so I was wondering what it was and how it was removed?

[Teleklos Archelaou]

I think it's just much much rarer now - others can give a fuller response but that's my understanding.

[Pharnakes]

Yes, but what was it? What happened when it occured?

[Karo]

When you had a battle were there was a reinforcment for your enemey or for you than you win the battle the game wouldd crash but that's a issuhe 0.73 and it was a real issuhe when you would fight the grey dead and they have reinforcment and you have a heroic victory many times there was a CTD

[Teleklos Archelaou]

When reinforcements took part in a battle basically. It was a lot more common in the past but they found some trait tricks that makes it much much less likely.

[MarcusAureliusAntoninus]

It was caused by faulty triggers for traits. I think it was 'enemies in battle' trigger or something. If the trigger for a trait is complex and the trigger includes counting units on the field, it would crash when you loaded out of the battle. Since it was only confused when multiple armies were on the field, it crashed during battles with reenforcements.

The bug still happens, very rarely. But in 7.x, it would happen about 50% of the time when there was 3 or more armies fighting.

[bovi]

To be precise, it is a bugged variable which we used as a conditional. NumEnemiesInBattle works fine most of the time, but in the combination of playing out the battle (IE not autoresolve) and having enemy reinforcements it would crash the game if the chance of the trigger in question struck. Took me months to find that one, and the rest of the team had spent several months before I even started on it, at least narrowing it down to a trait trigger issue. If you search my posts in the TWC forum you can see some of the :wall: taking place.

Anyway, we worked around it by using NumFriendsInBattle and battle odds instead. Possibly NumFriendsInBattle also crashes in some esoteric conditions, but hardly ever.

[Teleklos Archelaou]

Nice short summation - wow. What an incredibly nasty thing that was too. It's amazing you ever found it mate.

[abou]

Yeah, Bovi is a beast. I don't know how he does it, but he is certainly good at it. The man is a walking troubleshooting guide.

[bovi]

That particular one came from pure stubbornness in doing trial and error. Most are due to good tools (UltraEdit/-Compare, Oracle database, SysInternal's FileMon etc). And some professional experience hunting bugs in my own code.