UnitSize broken for Macedonia (and maybe others)

For my own modding purposes, I have commented the "hidden" attribute at the trait UnitSize to see to whom and when it is attributed. To my big surprise, Macedonia do not get it all! There are probably some other factions for which it may be broken. :help:
It works for Casse and KH, who get it at the beginning of the second turn.

Unfortunately I am not in a position to test for the rest of factions, so I would like to ask other players to verify whether it works for them properly.

Spoiler Alert, click show to read: 

(just search EDCT for "UnitSize" and than add ";" at the beginning of the line containing "hidden" - now you should see a trait "Huge/Large/Normal/Small Unit Size" at all your family members depending on what unitsize are you playing.)

If it is missing or inappropriate, please report it in this thread so the EB team can repair it more easily. :2thumbsup:

If it is working for you just fine, please report it here as well so that I can be properly ashamed for the false alert I have caused :embarassed:

:bow:

Thank you V.T., this looks like a very old problem. I believe I have a fix. I'll verify it and post here later.

Fix:

In data\world\maps\campaign\imperial_campaign\CAMPAIGN_SCRIPT.TXT:

Replace all instances of "Antigonos" with "Antigonos Argeades".

I also noticed that Antigonos is missing completely from the first event monitor, so after the first instance of

Code:

---

console_command give_trait "Yazil IlWatar" UnitSize 1

---

should add

Code:

---

console_command give_trait "Antigonos Argeades" UnitSize 1

---

This is VERY important, as the UnitSize is/should be the key to many a battle related trait (anything to do with number of troops etc.) - the conditions scale up and down based on this trait.

First of all, thank you Atilius for your advice how to fix it. Unfortunately, it seems that it is more serious than just an incorrect name of the Macedonian faction leader. For instance, Hayasdan shows "large" unit size where it should be "huge"...

Seems that another official fix to be issued very soon?

BTW: what about Hayasdan? (in which places and what should be changed?)

Uh...what is the Unitsize thingiemagig

OK, fixed internally. There are four event monitors in CAMPAIGN_SCRIPT.TXT that need to be modified. The numerical values being compared to GarrisonToPopulationRatio ought to be as follows:

monitor_event SettlementTurnStart SettlementName Armavir
and GarrisonToPopulationRatio < 0.075
console_command give_trait "Manivs Romanvs" UnitSize 1
...

monitor_event SettlementTurnStart SettlementName Armavir
and GarrisonToPopulationRatio > 0.075
and GarrisonToPopulationRatio < 0.15
console_command give_trait "Manivs Romanvs" UnitSize 2
...

monitor_event SettlementTurnStart SettlementName Armavir
and GarrisonToPopulationRatio > 0.15
and GarrisonToPopulationRatio < 0.3
console_command give_trait "Manivs Romanvs" UnitSize 3
...

monitor_event SettlementTurnStart SettlementName Armavir
and GarrisonToPopulationRatio > 0.3
console_command give_trait "Manivs Romanvs" UnitSize 4
...

If you can find more, we'll fix them.

If this is a widespread thing, will they all be collated and put into another fix in the stickied thread?

Yes, the fix will be updated. The earliest time I can do that is thursday however. It's odd though, as we specifically went through these among the last things we did before release. Must be a slip-up.

Updated the fix.

So Makedonia and Hayasdan were the only factions with faulty/missing UnitSize traits?

People have talked about battle triggers, but what is the actual impact of it being faulty? Does it just govern the Traits that Family Members get? Or is it wider than that?

I'm assuming this is only applicable when the given factions are controlled by the player, yes?

That's what I'm wondering; because if that's the case then there's no point me starting again.

It only affects family members, yes. It affects the Makedonian family regardless of which faction you're playing, however if you're among the other ones that are fixed, it affects all factions the same (except Makedonia, of course).

I'll give the whole thing a second look. Could've sworn I fixed it but apparently I did not... :embarassed:

Argh!

It's time to automate this one day, but the problem lies in the rather many files involved and their hideously limited helpfullness when it comes to extracting this particular bit of info.

And yes, I do have an (efficient) idea how to do it, though.

Hey Tellos, make sure to update first, I've added Marvin's fix to the steppe ones.

Ah, yes I noticed. After I had figure the new values out. :grin:

In any case, it *should* be bugfree now: fixed a few other factions too ...