Hayasdan raiding targets

I found something I believe is an error in the script.

After I was expecting to finally achieve the victory conditions with Hayasdan, absolutly nothing happend.
I owned all settlements, and I had raided all the targets.
I'm absolutely 100% certain, I did double check and even did a reraid.
Luckely it's been an awesome campaign, but now in 140BC I feel it's time to give it a rest.

Of course I decided to blame the the raiding targets, as they diden't stop blinking after pressing the "?".
As the rookie I am I did my share of searches on this forum for answers, and finally found out where to look in all the cuddled up files in the EB directory.

So when I checked the EBBS_SCRIPT and the Hayasdan section I found this:

Spoiler Alert, click show to read: 

dvance_advice_thread Hayasdan_raid_Thread

if I_CompareCounter hayasdanConqueredNisa = 0
settlement_flash_start Nisa
end_if

if I_CompareCounter hayasdanConqueredByzantion = 0
settlement_flash_start Byzantion
end_if

if I_CompareCounter hayasdanConqueredChersonesos = 0
settlement_flash_start Chersonesos
end_if

if I_CompareCounter hayasdanConqueredPantikapaion = 0
settlement_flash_start Pantikapaion
end_if

if I_CompareCounter hayasdanConqueredAlexandreia = 0
settlement_flash_start Alexandreia
end_if

if I_CompareCounter hayasdanConqueredSalamis = 0
settlement_flash_start Salamis
end_if

if I_CompareCounter hayasdanConqueredPella = 0
settlement_flash_start Pella
end_if

if I_CompareCounter hayasdanConqueredAthenai = 0
settlement_flash_start Athenai
end_if

if I_CompareCounter hayasdanConqueredSparte = 0
settlement_flash_start Sparte
end_if

if I_CompareCounter hayasdanConqueredSidon = 0
settlement_flash_start Sidon
end_if

end_if

Now every other faction uses the Vanilla RTW faction names.
The 4-5 others I checked at least.
As seen on this one here:

Spoiler Alert, click show to read: 

if I_LocalFaction armenia
advance_advice_thread Sauromatae_raid_Thread
if I_CompareCounter armeniaConqueredSusa = 0
settlement_flash_start Susa
end_if

if I_CompareCounter armeniaConqueredPersepolis = 0
settlement_flash_start Persepolis
end_if

if I_CompareCounter armeniaConqueredSeleukeia = 0
settlement_flash_start Seleukeia
end_if

if I_CompareCounter armeniaConqueredBabylon = 0
settlement_flash_start Babylon
end_if

if I_CompareCounter armeniaConqueredAntiocheia = 0
settlement_flash_start Antiocheia
end_if

if I_CompareCounter armeniaConqueredPella = 0
settlement_flash_start Pella
end_if

if I_CompareCounter armeniaConqueredDemetrias = 0
settlement_flash_start Demetrias
end_if

if I_CompareCounter armeniaConqueredSegestica = 0
settlement_flash_start Segestica
end_if

if I_CompareCounter armeniaConqueredPatavium = 0
settlement_flash_start Patavium
end_if

if I_CompareCounter armeniaConqueredBononia = 0
settlement_flash_start Bononia
end_if

if I_CompareCounter armeniaConqueredArctaunon = 0
settlement_flash_start Arctaunon
end_if

if I_CompareCounter armeniaConqueredVesontio = 0
settlement_flash_start Vesontio
end_if

Hayasdan on the other hand uses "hayasdan".
Well I'm just a rookie, and all I want to know is if this is causing the problem? :)
If not then I'll leave this campaign anyways, but if it is I hope it's helpfull.

I appologize if the post is hard to read or understand, but I'm very tired and tried to clean it. :)

Quote:

---

Originally Posted by Jurdagat

I

Spoiler Alert, click show to read: 

if I_LocalFaction armenia
advance_advice_thread Sauromatae_raid_Thread
if I_CompareCounter armeniaConqueredSusa = 0
settlement_flash_start Susa
end_if

if I_CompareCounter armeniaConqueredPersepolis = 0
settlement_flash_start Persepolis
end_if

if I_CompareCounter armeniaConqueredSeleukeia = 0
settlement_flash_start Seleukeia
end_if

if I_CompareCounter armeniaConqueredBabylon = 0
settlement_flash_start Babylon
end_if

if I_CompareCounter armeniaConqueredAntiocheia = 0
settlement_flash_start Antiocheia
end_if

if I_CompareCounter armeniaConqueredPella = 0
settlement_flash_start Pella
end_if

if I_CompareCounter armeniaConqueredDemetrias = 0
settlement_flash_start Demetrias
end_if

if I_CompareCounter armeniaConqueredSegestica = 0
settlement_flash_start Segestica
end_if

if I_CompareCounter armeniaConqueredPatavium = 0
settlement_flash_start Patavium
end_if

if I_CompareCounter armeniaConqueredBononia = 0
settlement_flash_start Bononia
end_if

if I_CompareCounter armeniaConqueredArctaunon = 0
settlement_flash_start Arctaunon
end_if

if I_CompareCounter armeniaConqueredVesontio = 0
settlement_flash_start Vesontio
end_if

Hayasdan on the other hand uses "hayasdan".
Well I'm just a rookie, and all I want to know is if this is causing the problem? :)
If not then I'll leave this campaign anyways, but if it is I hope it's helpfull.

I appologize if the post is hard to read or understand, but I'm very tired and tried to clean it. :)

---

Armenia Sauromatae's internal name not Hayastan and this is Sauromatae_raid_Thread :yes:

Quote:

---

Originally Posted by Atanamir

Armenia Sauromatae's internal name not Hayastan and this is Sauromatae_raid_Thread :yes:

---

Maybe I wasn't clear. :)

I used Sarumatae as an example of how others factions look like, see they use internal names.
In Sarumataes case it was "Armenia".
Unlike Hayasdan, who simply uses "Hayasdan".
I can bring up another faction if that was confusing.

Bottom line is:
Hayasdan isn't using an internal name on raiding targets, and I believe that is causing problems with the VC.
I might be wrong, but thought I check here.

Quote:

---

Originally Posted by Jurdagat

Maybe I wasn't clear. :)

I used Sarumatae as an example of how others factions look like, see they use internal names.
In Sarumataes case it was "Armenia".
Unlike Hayasdan, who simply uses "Hayasdan".
I can bring up another faction if that was confusing.

Bottom line is:
Hayasdan isn't using an internal name on raiding targets, and I believe that is causing problems with the VC.
I might be wrong, but thought I check here.

---

I'm afraid I cant offer too much help, but nonetheless I can confirm that you're not wrong, yes their internal name isn't Hayasdan (I think only the saka use a non-vanilla internal name).
From descr_star:

; ---------------------------------------------------------
; ######### romans_scipii - Hayasdan #########
; ---------------------------------------------------------

Cheers

Quote:

---

Originally Posted by Jurdagat

I found something I believe is an error in the script.

---

There's nothing wrong with the code. Those are script counters and could have been named "martiansConqueredXXX" without causing problems. That code also has absolutely nothing to do with fulfillment of victory condiditons.

To prevent the flashing after you dismiss the advisor, click his "X" button.

Oh well, unless there is something I don't understand about raiding.
I can't seem to understand why the victory screen never came up.
I conquered those provinces once and generally lost most of them again.
Correct me if I'm wrong, but there is nothing more to it as far as I know.

Thanks for clearing that Atilius.
This isn't a serious problem however, started a new campaign as Makedonia.
I simply just consider the Hayasdan one as completed. :)

Thanks for the awesome mod, I must say the Hayasdan campaign was the most enjoyable I ever did so far.

Quote:

---

Originally Posted by Jurdagat

I can't seem to understand why the victory screen never came up.

---

If you post a saved game, I'll see if there's a problem.

BTW, the Hayasdan can't win until the Seleukids have been destroyed. Are they still in the game?

Forgot to mention that, but yes they are destroyed.
Baktria finished the remains of them.
This is also a year or so after I should have recieved the message.

Savegame: http://www.axifile.com?4606094

It's on BI.exe by the way, if that makes a differance.

The game doesn't believe that you conquered Byzantion and Pella. Do it again, with armies led by a family member. Hold them for at least two turns.

Affirmative, will reraid them again when I get back from vacation.

Lots of thanks to, will be nice to finally get that victory screen to pop up.