Why hello there, I recently ran the EDTC and EDA through an ancillary and trait validation; and found out many things. This is what the validator said, and I will explain further:
Spoiler Alert, click show to read:
Code:
Error: Parsing EDCT failed, the followng errors were found:
Line 63355 - Error: Expecting Trigger - Found: ------------------------------------------[this means that the semicolon was missing from this line, it is a separator, so it should look like ;-------------------------------------- but apparently the semicolon was forgotten, and the trigger therefore, will not activate.]
Line 151058 - Error: Expecting Trigger - Found: ------------------------------------------ [this means that the semicolon was missing from this line, it is a separator, so it should look like ;-------------------------------------- but apparently the semicolon was forgotten, and the trigger therefore, will not activate.]
Error: Parsing EDA failed, the followng errors were found:
Line 6137 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Macedonia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6157 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Macedonia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6177 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Macedonia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6196 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Asia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6215 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Asia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6234 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Asia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6253 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Achaea 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6272 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Achaea 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6291 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Achaea 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6310 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Bithynia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6329 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Bithynia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6348 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Bithynia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6367 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Africa_Nova 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6386 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Africa_Nova 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6405 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Syria 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6424 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Syria 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6443 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Syria 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6460 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Judaea 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6479 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Gallia_Comata 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6499 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Cyrenacia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6519 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Cyrenacia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 6539 - Error: Invalid AcquireAncillary line, expected 'AcquireAncillary <ancillary> chance <percent>', found: AcquireAncillary Governor_of_Cyrenacia 1 Chance 100 [Meaning that this was formulated as a trait, where the "Affects" gives a treshold. The correct syntax with "AcquireAncillary" is the ancillary only and then the chance. So it should be "Acquire Ancillary Governor_of_Candyland Chance 100".]
Line 9130 - Error: Expecting Trigger - Found: ------------------------------------------ [this means that the semicolon was missing from this line, it is a separator, so it should look like ;-------------------------------------- but apparently the semicolon was forgotten, and the trigger therefore, will not activate.]
Also, something in the EBBS script.
Code:
Line 355442 - Error: Trait CasseBelgae is not defined. [Meaning there is no trait named "CasseBelgae" which is reffered to in the script]
So apparently, someone either chose to remove those triggers/ancillaries, or they did sloppy work :laugh4:
Well then, I hope this is answered, because we need the truth!
~Jirisys ()
08-15-2011, 04:07
vartan
Re: Ancillary and trait sloppiness! D:
Quote:
Originally Posted by jirisys
Well then, I hope this is answered, because we need the truth!
Considering the size of those files, having only a handful of errors is pretty good.
Also I'm at a loss as to what you feel needs to be answered, there are some errors in our files, what is you point?
08-15-2011, 14:40
jirisys
Re: Ancillary and trait sloppiness! D:
Quote:
Originally Posted by bobbin
Considering the size of those files, having only a handful of errors is pretty good.
Yes, my computer crashed because I ran a plugin to compare two versions :wall:.
Quote:
Also I'm at a loss as to what you feel needs to be answered, there are some errors in our files, what is you point?
Is that intentional? I mean, removing the governor of from actually working.
Because only the Governor ancillaries section is broken that way, the other things are minor mistakes, but it seems that you might have chosen to remove them. Either that or someone confused EDA with EDCT syntax.
If not, would the team make a fix to add to the 1.2 fixes?
~Jirisys ()
08-15-2011, 14:46
bobbin
Re: Ancillary and trait sloppiness! D:
No, given the nature of the errors it is unlikely to have been intentional, normally we would just delete the code or comment it out (;).
I'll pass it on to the rest of the team so it can be added to the fix list for 1.3, although it is likely to have already been noticed as the ATVTW is a pretty well know tool.
08-15-2011, 14:50
jirisys
Re: Ancillary and trait sloppiness! D:
Quote:
Originally Posted by bobbin
No, given the nature of the errors it is unlikely to have been intentional, normally we would just delete the code or comment it out (;).
I'll pass it on to the rest of the team so it can be added to the fix list for 1.3, although it is likely to have already been noticed as the ATVTW is a pretty well know tool.
I came up on that mistake because I read in the mods section that someone found mistakes with the ATVTW and posted corrections, but that was waaaaay back, so I thought I could check out what was wrong.
Alright then, glad to know. I have a working corrected EDA and EDTC if you want to save time and tedious effort. However the EBBS script reference to the CasseBelgae trait is something I didn't investigate further.
Anyways, great job. As you said, a handful of errors for a 240k lines text is impressive.
~Jirisys ()
08-15-2011, 17:07
XSamatan
Re: Ancillary and trait sloppiness! D:
Thanks for reporting, these errors are already fixed in our internal version. We will not release a temporary fix as they are not game-braking.
XSamatan
11-05-2011, 04:37
Vermin
Re: Ancillary and trait sloppiness! D:
So Jirisys, these corrections are now included in your mos packs? :) Please! :)
11-05-2011, 05:33
jirisys
Re: Ancillary and trait sloppiness! D:
Quote:
Originally Posted by Vermin
So Jirisys, these corrections are now included in your mos packs? :) Please! :)
Kind of, I think I already have the file made.
But not in the mod pack.
Let's not derail the previously-dead conversation.
