Expert Attacker

In my last 2 campaigns i've had 2 generals with expert attacker & when attacking the units in their armies did not get the extra +1 valour that this vice gives. I had Nur Al Din, rank 6 with the vice expert attacker, but when I attack all my units are only getting +3 valour instead of +4 from him. Also in my lastest Turkish campaign I have a general rank 4 with expert attacker & all units in battle are only getting +2 instead of +3 valour.
In my egptian campaigns all the historical generals that I get always get 1 bad vice very quick its normally pride or odd number of toes. Does anyone else have this happen when playing egyptians on expert?

I don't think the expert attacker applies to his troops. The virtue/vice usually says weather it adds to his troops stats. I.E. Look at 'fine leader' as it does apply.

What Insolent speaks of is the +1 valor awarded all troops under a generals command for every 2 command stars the general has.

I used to think this too. What i then noticed is that when you move the general into the province that you are attacking the number of command stars he has are updated. So if he gets +1 for attacking when outnumbered and he is the only unit in the province being attacked then he gets a bonus command star. The problem arrises when you star piling on more units as people tend not to check back when they have already done something. You may find that this general starts with the 6 or 8 stars that the virtue gives him but as more troops are added he loses one. Bummer I know.
I noticed this because I had a general with specialist defender and just sitting still he had 9 stars. But when I attacked with him, he only had 6. I was a bit shocked and sat down to work it out. It happens more often that you think.

No I know how the command vices works ie my general was rank 4 when defending, but he had the vice expert attacker which does not affect defence but when i move him to attack his stars would jump to 6 instead of 4, but in the battle the units in the army are only gaining +2 valour when they should be gaining +3

I haven't experienced this and I check a lot. It seems right to me the last time I played, IIRC.