Small fix for upgraded bodyguards

Just a little something I found while wading through the files. Scythia and Pontus have special upgraded bodyguard units. In 1.2 (at least), all upgraded bodyguards have general_unit_upgrade listed in the attributes line of their units. However, this is missing for Pontic and Scythian upgraded generals, which leads me to believe that they won't upgrade together with everybody else. So, in the export_decr_unit.txt for the units "barb scythian general scythian" and "east pontic general" add general_unit_upgrade at the end of the attributes line. In other words, the attributes line should end up with:

hardy, general_unit_upgrade

for both units. I haven't tested this in the campaign, since it would be a long wait for the reforms etc., but I think this is how it should be, since it's like that for all other bodyguard units.

Cheers,

i haven't noticed that yet but i think you're right, CA have forget typing lots of things

Hmmm, as far as I can see this only applies to the Scythian general. I can find no early version of the Pontic general, nor for that matter of the Briton general.

The following should clear it up (copied from EDU.txt with the rest of the lines snipped out):

type east generals cavalry early
dictionary east_generals_cavalry_early ; Eastern General
attributes sea_faring, general_unit, hide_forest, hardy
ownership eastern


type east generals cavalry
dictionary east_generals_cavalry ; Armoured Eastern General
attributes sea_faring, general_unit, hide_forest, hardy, general_unit_upgrade
ownership parthia, armenia


type east pontic general
dictionary east_pontic_generals ; Eastern General
attributes sea_faring, general_unit, hide_forest, hardy
ownership pontus

So, all eastern factions get the same early generals, while Parthia & Armenia should get cataphracts and Pontus should get a special one after the upgrade. Therefore, general_unit_upgrade is missing from the Pontic general's attribute line.

Cheers,

edit: Britons don't upgrade their generals: they always have charioteers as generals.

I think you are right. The changes look right anyway.

I can't remember, was this a problem in v1.1? I looked through the v1.1 data files and I don't see any general_unit_upgrade attributes. Is this a new attribute?

drone,

IIRC generals upgrades were not working at all in 1.1 if I remember the bug posts from others correctly. At least I never noticed them, but I think I only went through the drudgery of waiting for the reforms once or twice.

can't they do ANYTHING right?! argh, i'm not purposely trying to be hard on CA, more like Activision for limiting them to two patches and for providing such pitiful attention and resources to "quality ASSurance"... emphasis on the ASS

Quote:

---

Originally Posted by Red Harvest

drone,

IIRC generals upgrades were not working at all in 1.1 if I remember the bug posts from others correctly. At least I never noticed them, but I think I only went through the drudgery of waiting for the reforms once or twice.

---

So this is probably a new attribute to fix that issue. And since Pontus and Scythia are "nonplayable" factions, I can see how the testers could have missed it.

Quote:

---

Originally Posted by drone

So this is probably a new attribute to fix that issue. And since Pontus and Scythia are "nonplayable" factions, I can see how the testers could have missed it.

---

I think that is a correct assessment. And even if the beta testers reported it, I'm not sure how likely CA was to fix it. There were a number of apparent stat errors/discrepencies in the original file that were not addressed by the patch in any way--yet these had been reported in various bug threads for months. I will cut the beta testers quite a bit of slack, because they probably had very limited time to find all this, some things are hidden without modding, and even if they reported a problem, there was no guarrantee that it would be fixed.

ok, you're right. since they're not officially playable. same with the spanish not having long shield cav.

still, with a game this complex and epic, two patches (with the first one not even being a "real" patch of any sort) is pathetic and insulting. CA should demand more from activision just as much as we the consumers are demanding.

There are probably other "nonplayable" faction omissions as well.

hrvojej, not sure if this belongs in the Ludus Magna trait thread,
https://forums.totalwar.org/vb/showthread.php?t=44048
but this should get put somewhere permanent. Good find! :bow:

Quote:

---

Originally Posted by drone

hrvojej, not sure if this belongs in the Ludus Magna trait thread,
https://forums.totalwar.org/vb/showthread.php?t=44048
but this should get put somewhere permanent.

---

I thought about putting it there at first, but then I didn't want to interfere with the stated intention that the thread is about trait fixes. I'm all for having a fix thread, but I think that we should either make a new general fix thread, or ask therother to transform an existing one.

Quote:

---

Originally Posted by drone

There are probably other "nonplayable" faction omissions as well.

hrvojej, not sure if this belongs in the Ludus Magna trait thread,
https://forums.totalwar.org/vb/showthread.php?t=44048
but this should get put somewhere permanent. Good find! :bow:

---

There sure are... Take a look at the Thracian bodyguards and the upgraded ones. They are exactly the same.
Now this could of course be intended (which I actually think it is), but then that makes a late Thracian faction rather weak in regards of their family members. Very uncool since everybody else is supposed to get better bodyguards (that they get them is another matter).
Since the Thracian upgraded bodyguards are using the gothic cav model I have upgraded them to use their stats.

Quote:

---

Originally Posted by hrvojej

I thought about putting it there at first, but then I didn't want to interfere with the stated intention that the thread is about trait fixes. I'm all for having a fix thread, but I think that we should either make a new general fix thread, or ask therother to transform an existing one.

---

Hmm, good point hrvojej. Perhaps we should have a thread for fixes similar to this – has there been a number of similar bugs identified? In any case, you can post it in the LM trait thread if you want - we can always move it to a new thread at a later date.

Quote:

---

Originally Posted by therother

– has there been a number of similar bugs identified?

---

The "Selucid armored elephants to go" bug, the disappearing pikemen for thrace, the blue spanish generals, the infamous HA bug, I know I'm missing at least two more.

Quote:

---

Originally Posted by Pode

The "Selucid armored elephants to go" bug, the disappearing pikemen for thrace, the blue spanish generals, the infamous HA bug, I know I'm missing at least two more.

---

Also, mercenary roster missing HA in region Armenia, praetorians and cavalry auxilia before the reforms, Gaul fanatics in Dacian shrines, and most would argue Spanish long shield cavalry and onagers as well.

However, I don't have time right now for comprehensive post, I'm afraid.

aw man... cavalry auxillia are a post-marius unit too, huh?

Auxillia in the name is kind of a giveaway, although I left them as otherwise that level of stables doesn't do anything pre Marius.

Quote:

---

Originally Posted by Pode

The "Selucid armored elephants to go" bug, the disappearing pikemen for thrace, the blue spanish generals, the infamous HA bug, I know I'm missing at least two more.

---

Ah, okay then. I'll open up a new thread for unit fixes.

No, the cav. auxilia are meant to be pre-Marius, they have a (pm) next to them in the tech tree that came with the game (backside of the map.) That is not unreasonable for the time period. Their allies undoubtedly had some javelin cav pre-Marius.

Thread open - Research: Fixes for bugs in the unit file.

Quote:

---

Originally Posted by hrvojej

Gaul fanatics in Dacian shrines

---

Ah... Now I found it. Looked at the proper shrine and found the dacian version, only just happened to look at the farming shrine.