Senate offices as traits

Malrubius from EB has helped me a bit with this already, but i've come across a problem. I have a unified rome in my mod, using the julii. So the senate is removed so no senate offices/senate missions. But after hearing that EB had senate offices in i decided to pm malrubius about it and try and do this myself. I forgot about this for a bit(making all the sprites for a mod will do that to you), but i decided to give it another go recently. I have a modified version of his GAFH mod in my mod. I added in some of the traits and triggers he said, modified to work with my mod, and loaded up a camapign. It seemed to work, with me now having a few people with the Quaestor office. But no one was getting any of the other offices, they would just be a Quaestor, serve their term then become and ex-Quaestor(thanks to malrubius for the help with the term lengths as well). The triggers should be working as they are only slightly modified versions of the EB ones, modified to fit in with the traits i have in my mod so it should work. Now im at college at the moment so i cant post the code, which i will do later, but does have any ideas now what may be wrong?

Heres the code:

Code:

---

Trait Aedile
    Characters family
    AntiTraits notAedile

    Level Office_of_Aedile
        Description Office_of_Aedile_desc
        EffectsDescription Office_of_Aedile_effects_desc
        Threshold  1

        Effect Management  1
        Effect Law  1



;------------------------------------------
Trait Censor
    Characters family
    AntiTraits notCensor

    Level Office_of_Censor
        Description Office_of_Censor_desc
        EffectsDescription Office_of_Censor_effects_desc
        Threshold  1

        Effect Influence  2
        Effect Management  2



;Mod145 - 11/02 : reduced influence bonus to 2
;------------------------------------------
Trait Consul
    Characters family
    AntiTraits notConsul

    Level Office_of_Consul
        Description Office_of_Consul_desc
        EffectsDescription Office_of_Consul_effects_desc
        Threshold  1

        Effect Influence  2
        Effect Command  1
        Effect Management  1


;Mod146 - 11/02 : reduced command bonus by 1
;------------------------------------------
Trait PontifexMaximus
    Characters family
    AntiTraits notPontifexMaximus

    Level Office_of_Pontifex_Maximus
        Description Office_of_Pontifex_Maximus_desc
        EffectsDescription Office_of_Pontifex_Maximus_effects_desc
        Threshold  1

        Effect Influence  4



;Mod142 - 11/02 : reduced influence to 4
;------------------------------------------
Trait Praetor
    Characters family
    AntiTraits notPraetor

    Level Office_of_Praetor
        Description Office_of_Praetor_desc
        EffectsDescription Office_of_Praetor_effects_desc
        Threshold  1

        Effect Management  1
        Effect Law  2



;------------------------------------------
Trait Quaestor
    Characters family
    AntiTraits notQuaestor

    Level Office_of_Quaestor
        Description Office_of_Quaestor_desc
        EffectsDescription Office_of_Quaestor_effects_desc
        Threshold  1

        Effect Management  1



;------------------------------------------
Trait notAedile
    Characters family
    AntiTraits Aedile

    Level Ex_Aedile
        Description Ex_Aedile_desc
        EffectsDescription Ex_Aedile_effects_desc
        Threshold  1

        Effect Law  1



;------------------------------------------
Trait notCensor
    Characters family
    AntiTraits Censor

    Level Ex_Censor
        Description Ex_Censor_desc
        EffectsDescription Ex_Censor_effects_desc
        Threshold  1

        Effect Management  1



;Mod143 - 11/02 : removed inf bonus, added +1 management
;------------------------------------------
Trait notConsul
    Characters family
    AntiTraits Consul

    Level Ex_Consul
        Description Ex_Consul_desc
        EffectsDescription Ex_Consul_effects_desc
        Threshold  1

        Effect Command  1



;------------------------------------------
Trait notPontifexMaximus
    Characters family
    AntiTraits PontifexMaximus

    Level Ex_Pontifex_Maximus
        Description Ex_Pontifex_Maximus_desc
        EffectsDescription Ex_Pontifex_Maximus_effects_desc
        Threshold  1

        Effect Influence  2



;Mod144 - 11/02 : reduced inf bonus to 2
;------------------------------------------
Trait notPraetor
    Characters family
    AntiTraits Praetor

    Level Ex_Praetor
        Description Ex_Praetor_desc
        EffectsDescription Ex_Praetor_effects_desc
        Threshold  1

        Effect Law  1



;------------------------------------------
Trait notQuaestor
    Characters family
    AntiTraits Quaestor

    Level Ex_Quaestor
        Description Ex_Quaestor_desc
        EffectsDescription Ex_Quaestor_effects_desc
        Threshold  1

        Effect Influence  1

;------------------------------------------
Trait TurnsInOffice
    Characters family
    Hidden
    NoGoingBackLevel 4
    AntiTraits TurnsOutOfOffice

    Level In_Office
        Description In_Office_desc
        EffectsDescription In_Office_effects_desc
        Threshold  1

    Level One_Year_In
        Description One_Year_In_desc
        EffectsDescription One_Year_In_effects_desc
        Threshold  4

    Level Eighteen_Months_In
        Description Eighteen_Months_In_desc
        EffectsDescription Eighteen_Months_In_effects_desc
        Threshold  6

;------------------------------------------
Trait TurnsOutOfOffice
    Characters family
    Hidden
    NoGoingBackLevel 3
    AntiTraits TurnsInOffice

    Level One_Year_Out
        Description One_Year_Out_desc
        EffectsDescription One_Year_Out_effects_desc
        Threshold  4

Trigger Elected_Quaestor
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive < 2
            and Attribute Influence > 2
          and Trait Quaestor < 1

    Affects Quaestor  1  Chance  25

;------------------------------------------
Trigger Elected_Aedile
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 2
            and Trait TurnsAlive < 5
            and Attribute Influence > 2
            and Attribute Management > 2
          and Trait Aedile < 1
          and Trait notAedile < 1

    Affects Aedile  1  Chance  50

;------------------------------------------
Trigger Elected_Praetor
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 3
            and Trait TurnsAlive < 7
            and Attribute Influence > 4
            and Attribute Management > 4
          and Trait Praetor < 1
          and Trait notPraetor < 1

    Affects Praetor  1  Chance  50

;------------------------------------------
Trigger Elected_Consul
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 4
            and Trait TurnsAlive < 9
            and Attribute Influence > 6
            and Attribute Command > 4
            and Attribute Management > 5
          and Trait Consul < 1
          and Trait notConsul < 1

    Affects  Consul 1  Chance  50

;------------------------------------------
Trigger Elected_Censor
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 5
            and Trait TurnsAlive < 10
            and Attribute Influence > 8
            and Attribute Management > 7
          and Trait Censor < 1
          and Trait notCensor < 1

    Affects  Censor 1  Chance  50

;------------------------------------------
Trigger Elected_PontifexMaximus
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 2
            and Trait TurnsAlive < 7
            and Attribute Influence > 5
          and Trait PontifexMaximus < 1
          and Trait notPontifexMaximus < 1

    Affects  PontifexMaximus 1  Chance  25

;------------------------------------------
Trigger Count_Quaestor_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Quaestor > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_Aedile_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Aedile > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_Praetor_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Praetor > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_Consul_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Consul > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_Censor_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Censor > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_PontifexMaximus_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait PontifexMaximus > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Reset_Quaestor_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Quaestor > 0

    Affects notQuaestor  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_Aedile_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Aedile > 0

    Affects notAedile  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_Praetor_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Praetor > 0

    Affects notPraetor  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_Consul_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Consul > 0

    Affects notConsul  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_Censor_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Censor > 0

    Affects notCensor  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_PontifexMaximus_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait PontifexMaximus > 0

    Affects notPontifexMaximus  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

---

Now can anyone help me work out why only Quaestor works, and can anyone suggest a set of triggers that would mean you have to have one rank before the next, except for Pontifex Maximus which will be independent of the rest.

Edit by Myrddraal: Put [code] brackets around the code to make it easier to read

Here are the TurnsAlive traits and triggers referred to in the triggers for the offices

Code:

---

Trait TurnsAlive
    Characters family

    Level Youth
        Description Youth_desc
        EffectsDescription Youth_effects_desc
        Threshold  1
       
          Effect HitPoints  1

    Level Middle_Aged
        Description Middle_Aged_desc
        EffectsDescription Middle_Aged_effects_desc       
        Threshold  48

        Effect MovementPoints  -1

    Level Senior_Citizen
        Description Senior_Citizen_desc
        EffectsDescription Senior_Citizen_effects_desc       
        Threshold  88

        Effect MovementPoints  -2
          Effect HitPoints  -1

    Level Elderly
        Description Elderly_desc
        EffectsDescription Elderly_effects_desc       
        Threshold  108

        Effect MovementPoints  -3
        Effect HitPoints  -2

;------------------------------------------
Trigger general_ages_one_turn
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait CharacterAges = 1

    Affects TurnsAlive  1  Chance  100   
;------------------------------------------
Trigger general_starting_age
    WhenToTest CharacterComesOfAge

    Affects TurnsAlive  1  Chance  100
    Affects CharacterAges  1  Chance  100

---

Edit by Myrddraal: Put [code] brackets around the code to make it easier to read

I think it's the Turns Alive < lines. Qaestor is the only one that doesn't have it.
It's probably not working like you think it is.

Quaestor does have that line, its missing the turnsalive > line, ill try it without that, i've tried some other triggers with moderate success ill post back here to see if it works or not.

Nvm, i've sorted it out myself, this can be closed.

Right, i could still use some help with the triggers, the offices are working fine, its just characters do not really progress through them, any ideas on better triggers?

Code:

---

;------------------------------------------
Trigger Elected_Quaestor
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive < 3
            and Attribute Influence > 2
          and Trait Quaestor < 1
          and Trait Censor < 1
          and Trait Praetor < 1
          and Trait Aedile < 1
          and Trait Consul < 1
          and Trait PontifexMaximus < 1

    Affects Quaestor  1  Chance  25

;------------------------------------------
Trigger Elected_Aedile
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 3
            and Attribute Influence > 2
            and Attribute Management > 1
          and Trait Aedile < 1
          and Trait notAedile < 1
          and Trait Censor < 1
          and Trait Praetor < 1
          and Trait Consul < 1
          and Trait Quaestor < 1
          and Trait PontifexMaximus < 1

    Affects Aedile  1  Chance  50

;------------------------------------------
Trigger Elected_Praetor
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 4
            and Attribute Influence > 4
            and Attribute Management > 0
          and Trait Praetor < 1
          and Trait notPraetor < 1
          and Trait Censor < 1
          and Trait Consul < 1
          and Trait Aedile < 1
          and Trait Quaestor < 1
          and Trait PontifexMaximus < 1

    Affects Praetor  1  Chance  50

;------------------------------------------
Trigger Elected_Consul
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 5
            and Attribute Influence > 5
            and Attribute Command > 2
            and Attribute Management > 0
          and Trait Consul < 1
          and Trait notConsul < 1
          and Trait Censor < 1
          and Trait Praetor < 1
          and Trait Aedile < 1
          and Trait Quaestor < 1
          and Trait PontifexMaximus < 1

    Affects  Consul 1  Chance  50

;------------------------------------------
Trigger Elected_Censor
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 6
            and Attribute Influence > 6
            and Attribute Management > 0
          and Trait Censor < 1
          and Trait notCensor < 1
          and Trait Consul < 1
          and Trait Praetor < 1
          and Trait Aedile < 1
          and Trait Quaestor < 1
          and Trait PontifexMaximus < 1

    Affects  Censor 1  Chance  50

;------------------------------------------
Trigger Elected_PontifexMaximus
    WhenToTest CharacterTurnStart

    Condition FactionType romans_julii
          and AgentType = family
            and Trait TurnsAlive > 3
            and Attribute Influence > 5
          and Trait PontifexMaximus < 1
          and Trait notPontifexMaximus < 1
          and Trait Censor < 1
          and Trait Consul < 1
          and Trait Praetor < 1
          and Trait Aedile < 1
          and Trait Quaestor < 1

    Affects  PontifexMaximus 1  Chance  10

;------------------------------------------
Trigger Count_Quaestor_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Quaestor > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_Aedile_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Aedile > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_Praetor_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Praetor > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_Consul_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Consul > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_Censor_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait Censor > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Count_PontifexMaximus_Turns_in_Office
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait PontifexMaximus > 0

    Affects TurnsInOffice  1  Chance  100

;------------------------------------------
Trigger Reset_Quaestor_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Quaestor > 0

    Affects notQuaestor  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_Aedile_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Aedile > 0

    Affects notAedile  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_Praetor_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Praetor > 0

    Affects notPraetor  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_Consul_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Consul > 0

    Affects notConsul  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_Censor_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait Censor > 0

    Affects notCensor  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

;------------------------------------------
Trigger Reset_PontifexMaximus_after_Term_Expires
    WhenToTest CharacterTurnEnd

    Condition AgentType = family
            and Trait TurnsInOffice = 2
          and Trait PontifexMaximus > 0

    Affects notPontifexMaximus  2  Chance  100
    Affects TurnsOutOfOffice  4  Chance  100

---