Problem with missing faction-leader traits

The situation is that Pontos lacks a trait for the faction leader, although it has the usual trait ("Koiranides") for the faction heir with the usual effects, which has the odd side effect that the heir gets more Influence, personal security and therefore bodyguards than the king all other things being equal. Saba in turn lacks both. I tried to make suitable placeholder traits to fix the issues because that was sor tof annoying.

The one for Pontos worked well enough - I basically just copy-pasted the "Basileus" trait triggers and altered the faction IDs as necessary. The trait and triggers look like this if someone wants to use them:

Spoiler Alert, click show to read: 

Code:

---

Trait Basileus
    Characters family
    AntiTraits Koiranides

    Level Basileus
        Description Basileus_desc
        EffectsDescription Basileus_effects_desc
        Threshold  1

        Effect Influence  2
        Effect Law  2
        Effect Command  1
        Effect TroopMorale  1
        Effect PersonalSecurity  3

---

Spoiler Alert, click show to read: 

Code:

---

;------------------------------------------
Trigger Pontos_is_Basileus
    WhenToTest CharacterTurnStart

    Condition IsFactionLeader
          and Trait Basileus < 1
          and FactionType carthage

    Affects Basileus  1  Chance  100
    Affects Factionheir  1  Chance  100
    Affects Exheir  1  Chance  100
    Affects Noble  1  Chance  100

;------------------------------------------
Trigger Pontos_Becomes_Basileus
    WhenToTest BecomesFactionLeader

    Condition FactionType carthage

    Affects Basileus  1  Chance  100

;------------------------------------------

---

These aren't very savegame compatible mind you - when I reloaded my ongoing Pontos campaign they kinda screwed up all the characters' traits up to and including ethnicities, but seemed to work fine when I briefly tested them in a new campaign.

The problems came when I tried to adapt the whole factionleader/heir trait thingy and the relevant triggers for Saba. I created a "Malek" trait for the leader by copy-pasting and slightly altering the standard leader traits - the result looks like this:

Spoiler Alert, click show to read: 

Code:

---

;Trait: Malek
; o Malek: <Influence>  2, <Law> 2, <Command> 1, <TroopMorale> 1 , <PersonalSecurity>  3

Trait Malek
    Characters family
    AntiTraits Prince

    Level Malek
        Description Malek_desc
        EffectsDescription Malek_effects_desc
        Threshold  1

        Effect Influence  2
        Effect Law  2
        Effect Command  1
        Effect TroopMorale  1
        Effect PersonalSecurity  3

---

,

...which should be correct enough (I used the existing generic "Prince" trait for the heir). I also created the appropriate trait description in export_VnVs.txt by the same method. The triggers I adapted from the existing ones for other factions, and they look as follows:

Spoiler Alert, click show to read: 

Code:

---

;------------------------------------------
Trigger Saba_is_Malek
    WhenToTest CharacterTurnStart

    Condition IsFactionLeader
          and Trait Malek < 1
          and FactionType saba

    Affects Malek  1  Chance  100
    Affects Factionheir  1  Chance  100
    Affects Exheir  1  Chance  100
    Affects Noble  1  Chance  100

;------------------------------------------
Trigger Saba_Becomes_Malek
    WhenToTest BecomesFactionLeader

    Condition FactionType saba

    Affects Malek  1  Chance  100

;------------------------------------------
Trigger Saba_reinherited_Prince
    WhenToTest BecomesFactionHeir

    Condition Trait ExPrince = 1
          and FactionType saba

    Affects Prince  1  Chance  100

;------------------------------------------
Trigger Saba_disinherited_Prince
    WhenToTest CeasedFactionHeir

    Condition not Trait ExPrince = 1
          and not IsFactionLeader
          and FactionType saba

    Affects ExPrince  2  Chance  100

;------------------------------------------
Trigger Saba_inherited_Prince
    WhenToTest CeasedFactionHeir

    Condition IsFactionLeader
          and FactionType saba

    Affects ExPrince  1  Chance  100

;------------------------------------------
Trigger Saba_is_heir_Prince
    WhenToTest CharacterTurnStart

    Condition IsFactionHeir
          and FactionType saba
          and Trait Prince < 1

    Affects Prince  1  Chance  100

;------------------------------------------
Trigger Saba_becomesheir_Prince
    WhenToTest BecomesFactionHeir

    Condition FactionType saba

    Affects Prince  1  Chance  100

;------------------------------------------

---

These should work as the syntax is identical to those used in the existing triggers, save for the factional references.

They don't, though. Trying to start a new campaign with them in results in an immediate CTD without explanations. Which suggests I've done something wrong, or overlooked something I probably don't even know of. Could someone more clever point out what went wrong, as it is leaving me baffled ?

Quote:

---

Originally Posted by Watchman

The situation is that Pontos lacks a trait for the faction leader, although it has the usual trait ("Koiranides") for the faction heir with the usual effects, which has the odd side effect that the heir gets more Influence, personal security and therefore bodyguards than the king all other things being equal.

---

This was remedied about 2 months ago in our internal build. You'll see it's correct in the next release.

Quote:

---

Originally Posted by Watchman

Saba in turn lacks both. I tried to make suitable placeholder traits to fix the issues because that was sort of annoying.

---

I don't see the problem. You know that your Basileus_desc and Basileus_effects_desc labels are working OK, so try using

Code:

---

        Description Basileus_desc
        EffectsDescription Basileus_effects_desc

---

in place of

Code:

---

        Description Malek_desc
        EffectsDescription Malek_effects_desc

---

just to make sure that there isn't something wrong with the Malek labels you put into export_VnVs.txt. I'm afraid that's all I can recommend right now. Perhaps BozosLiveHere will happen by and see something I'm missing.

I can't find anything wrong with the triggers either. Maybe it's something in export_VnVs.

Oh, and I have to thank you twice: once for making me realize I should have added Koiranides as an AntiTrait for Basileus and another for reminding me I should be pestering people about leader and heir traits for Saba.

You're welcome. :beam: Hmm. I'll try making the Saba use one of the the proven-to-work leader-traits then. No need to be too demanding with placeholders, natch.