More than two turns a year - release

[The_Mark]

Shouldn't the "suspend_unscripted_advice" command prevent her from popping up while the script is running?

[Myrddraal]

It should yes. I seem to remember that needs to be run at the beginning of each turn. In the meantime. The link is back up with the corrected ScriptGen

[MajorFreak]

hooray!!!

[Mammut]

I have tried now a couple of times but it doesn't work for me. I do as you say in your first post except for Im using the script gen. Im using RTR 5.4.1 if that is any help...

[Myrddraal]

Are you using the new script gen? The one I just uploaded?

Does the script run at all?

[Mammut]

Are you using the new script gen? The one I just uploaded?

Does the script run at all?

well what do you mean with "just"? I uploaded it some 1 hour before I wrote the post.

When I run the script I get up a menu were I can choose what file to script and I push a button which says "generate" and a progress bar fills up. But now is there only one file to script or are there more? A small readme might be good have if there is more things to do.

[Epistolary Richard]

There are installation instructions in the first post of this thread. Is there any other information that you need?

[[cF]HanBaal]

Unfortunately using the endturn button wouldn't work because the game would then start going into the AI factions - giving only a limited amount of time to press the showmehow button.

I see. It would be indeed a not-so-good solution.

------------

There should be a way of ensuring that it only appears once, which I thought was already inherent in the advice thread but evidently not. The effect of the advice thread variables - though they appear obvious - haven't been properly documented so finding a solution for this approach is a matter of trial and error.

Shouldn't the "suspend_unscripted_advice" command prevent her from popping up while the script is running?

It should yes. I seem to remember that needs to be run at the beginning of each turn

I'm waiting eagerly for a successful update on this by either you or Myrdraal! Any success? This is the final step for making the 4turn-year mod perfect so I (and many mods' team members) would be VERY apreciated if anyone with time and skill could look into it asap...please

------

If anyone out there has the skills and time but feels this is a not so important feature to waste your precious time, please consider on these important advantages:

-more realistic movements and actions/reactions (the "time bandits" expression a member of the mod I'm working on mentioned, sums the irrealistic consequence that would happen if armies would be given realistic 6month movement points);

-realistic aging in relation to moves' range (Alexander wouldn't be dead before he reached India);

-more realistic training&building times&diferentiation (most basic units won't take 6months anylonger to get recruited and in fact the whole training/building system would actually be perfected due to a better diferentiation)

-a realistic snow season (instead of inadequately having snow 6months per year on many regions)

Cmon people, we're closer than ever to make rtw SOOO much better

[Shigawire]

Hear hear!

Let's be solution-oriented!

[Mammut]

There are installation instructions in the first post of this thread. Is there any other information that you need?

I missread what he wrote in the first post. I thought the instructions was for doing it manually and not using a script generator.

[Myrddraal]

No, you need to follow them

[[cF]HanBaal]

*bump*

https://forums.totalwar.org/vb/showp...8&postcount=38

Could you at least reply to the above Myrddraal? If I understand, your current script still hasn't a way yet to ALWAYS remind people to press F1 after each load correct? Can't you or Epistolary Richard look at that UI buttons' trigger suggestion to ALWAYS remind us by E.R. and complete it with that "suspend_unscripted_advice command" to make it perfect and nonrepetitive? Please mates, this is the final step.

[Epistolary Richard]

I haven't used "suspend_unscripted_advice" before, but I'll give it a try this evening (or the wee hours of the morning more likely). And even if we keep the advisor under wraps it's not an ideal solution because the player still has to press a UI button before pressing end turn.

Plus, of course, it might well stop the advisor popping up for any other reason.

Edit: Later that day...

Okay, I put in "suspend_unscripted_advice" each turn as Myrddraal suggested and it seemed to work both for new games and for reloads. This is the script that I've been using, it's one of Myrddraal's early versions, before the script generator. As you see, it just has "suspend_unscripted_advice" each turn.

script

	suspend_unscripted_advice true
	suspend_during_battle on

	console_command date -50
	console_command season summer

	while I_TurnNumber = 0
	end_while

	suspend_unscripted_advice true
	disable_shortcuts options_button true
	console_command date -50
	console_command season summer

	while I_TurnNumber = 1
	end_while

	suspend_unscripted_advice true
	console_command date -50
	console_command season summer

	while I_TurnNumber = 2
	end_while
	suspend_unscripted_advice true
	console_command date -50
	console_command season winter

	while I_TurnNumber = 3
	end_while
	suspend_unscripted_advice true
	disable_shortcuts options_button false
	console_command date -51
	console_command season summer

	while I_TurnNumber = 4
	end_while

	suspend_unscripted_advice true
	disable_shortcuts options_button true
	console_command date -51
	console_command season summer

	while I_TurnNumber = 5
	end_while
	suspend_unscripted_advice true
	console_command date -51
	console_command season summer

	while I_TurnNumber = 6
	end_while
	suspend_unscripted_advice true
	console_command date -51
	console_command season winter

	while I_TurnNumber = 7
	end_while

	suspend_unscripted_advice true
	disable_shortcuts options_button false
	console_command date -52
	console_command season summer

	while I_TurnNumber = 8
	end_while
	suspend_unscripted_advice true
	disable_shortcuts options_button true
	console_command date -52
	console_command season summer

	while I_TurnNumber = 9
	end_while
	suspend_unscripted_advice true
	console_command date -52
	console_command season summer

	while I_TurnNumber = 10
	end_while
	suspend_unscripted_advice true
	console_command date -52
	console_command season winter

	while I_TurnNumber = 11
	end_while
	suspend_unscripted_advice true
	disable_shortcuts options_button false
	console_command date -53
	console_command season summer

	while I_TurnNumber = 12
	end_while
	suspend_unscripted_advice true
	disable_shortcuts options_button true
	console_command date -53
	console_command season summer

	while I_TurnNumber = 13
	end_while
	suspend_unscripted_advice true
	console_command date -53
	console_command season summer

	while I_TurnNumber = 14
	end_while
	suspend_unscripted_advice true
	console_command date -54
	console_command season summer

	while I_TurnNumber = 15
	end_while


end_script

... with this trigger

------------------------------------------

Trigger 2150_Multiple_Turns_Trigger
    WhenToTest ButtonPressed

    AdviceThread Help_Campaign_Keyboard_Shortcuts_Scroll_Thread  0

With this method, pressing any one of the following buttons will bring up the advisor. You have to click on her and she'll start talking about the 4 turns script, then click on show me how and it'll run it.

I didn't try refusing the advice - I assume if you do, she won't appear again.

Note, also I found that requested advice still seems to appear.


Edit: Even later that day...

Okay, there's another problem. The advisor stays away right up until I go into a battle. As soon as I come out and hit a button then she pops back up. The solution may be no more complicated than repeating the suspend during battle line in the same way as the suspend unscripted advice...

[Mammut]

I have done as you have written in your first post Myrddraal but it still doesn't work. The advisor do say that if I click on the "show me how" button it will be activated but the button is greyed out (mybe supposed to be?). I have also tried with waiting a few minuites before doing anything from the beginning.

I wonder if the text within the () just down below is supposed to be in the file.

4.
Open export_advice.txt in Data\text
Add to the bottom of this file the following text:
;-------------------

{four_turns_Title} (Four turns a year)

{four_turns_Text1}
(To finish loading the four turns a year script, click
on the 'Show me how' button. Remember, you must do
this every time you load a saved game.)

[Mammut]

In the file export_descr_advice there are two places which says:

AdviceThread
Help_Campaign_Keyboard_Shortcuts_Scroll_Thread

the first only says like above then there are another one futher down that looks like this:

;------------------------------------------
Trigger 2137_Help_Campaign_Keyboard_Shortcuts_Scroll_Trigger
WhenToTest ScrollAdviceRequested

Condition ScrollAdviceRequested help_scroll

AdviceThread Help_Campaign_Keyboard_Shortcuts_Scroll_Thread 0

Are Im supposed to change anything here too?

[Myrddraal]

you don't change the trigger one

[Mammut]

Thanks for the help Myrddraal but I have to give up on this. I simply dont have the knowledge to correct the problem.

It is a good mod as it would be more correct then the 2 turns years that CA made. I hope it will be included in RTR as it would do a lot for the game.

[Myrddraal]

I'll upload the files eventually then it should be an easy install

[khelvan]

What happens if the player does not run the script upon loading? It simply runs 2 turns a year with no other adverse effects? What if upon a second load the player hits F1. Will this cause issues?

[[cF]HanBaal]

I haven't used "suspend_unscripted_advice" before, but I'll give it a try this evening (or the wee hours of the morning more likely).

Thx for giving it a try

----

Okay, I put in "suspend_unscripted_advice" each turn as Myrddraal suggested and it seemed to work both for new games and for reloads. This is the script that I've been using, it's one of Myrddraal's early versions, before the script generator. As you see, it just has "suspend_unscripted_advice" each turn.

That's great news! If no bugs appear this means the main problem (advisor repetitiveness) is solved.

Okay, there's another problem. The advisor stays away right up until I go into a battle. As soon as I come out and hit a button then she pops back up. The solution may be no more complicated than repeating the suspend during battle line in the same way as the suspend unscripted advice...

I believe that if it worked before that same "suspend advice" command can also properly function in this situation too. And I seriously hope those "..." you put in the end mean you meant taking another look at it eh?

And even if we keep the advisor under wraps it's not an ideal solution because the player still has to press a UI button before pressing end turn.

That's not even a problem I believe. If I understand correctly the advisor will pop up after we load/start campaign and every time we press any of the training/building/faction UI buttons right? I believe any player always presses at least one of those, after loading/starting any campaign even if it is just for a quick overlook. Even if he doesn't (which I think will be a 1 in a million case) and since the advisor also pops up when we press end turn (right?), the player will immediately understand he 'forgot' to start the script before ending the turn... and reload again. But as I said, I don't believe this is going to happen.

-----------------


Final question:

Do we need to have the advisor on to get this 'reminder'? If so, is it possible to "suspend" EVERY other advice? If not, can we at least have it at 'low advice level'?

[Myrddraal]

What happens if the player does not run the script upon loading? It simply runs 2 turns a year with no other adverse effects? What if upon a second load the player hits F1. Will this cause issues?

If the player forgets to run the script the first turn, or starts the script after playing a bit of normal two turns, when he runs the script, the date and season will revert to what they would have been had the script been run from the beginning. The only adverse effect I can think of is that people who had grown older would keep the years they had aquired without the script running.

Okay, there's another problem. The advisor stays away right up until I go into a battle. As soon as I come out and hit a button then she pops back up. The solution may be no more complicated than repeating the suspend during battle line in the same way as the suspend unscripted advice...

The suspend during battle line stops the script being cancelled if a battle is played. This means you don't have to start the script again after every battle.

I've tried this solution before, but whatever you do, you can't have the advisor pop up immediately on load. The user has to do something. Like you can make the advisor pop up on selection of an army or anything, but there has to be something. There is no trigger: onload as far as I know.

[The_Mark]

but whatever you do, you can't have the advisor pop up immediately on load

Yes you can. A trigger that checks if turn number > 0 will return always true, popping up at the start of a turn.

Also, shouldn't advancing the advice thread in question forward prevent her from popping up?

[Myrddraal]

Stupid me...

[Epistolary Richard]

Do we need to have the advisor on to get this 'reminder'? If so, is it possible to "suspend" EVERY other advice? If not, can we at least have it at 'low advice level'?

No, you don't need to have the advisor on. The conditionals on whether or not the advisor appears when the trigger is activated are listed in the AdviceThread lines which I really don't understand properly. Needless to say, there are some advice threads such as 'Why don't you consider moving your troops, you lazy dumb-ass?" which are turned off and some such as the advice threads that are actually requested which are still on.

Yes you can. A trigger that checks if turn number > 0 will return always true, popping up at the start of a turn.

What event would you tie that trigger to? Would a factionturnstart event work if you reloaded a game that had been saved in the middle of your turn?

[The_Mark]

Gah. Why can't the advisor only check a condition...

Stupid me...

I deserved that. Thanks.

[Myrddraal]

Um, I wasn't being sarcastic... (perhaps that was a bad smilie) But now you say it, I remember why I said the first thing. Thats right it has to check an event!

Now I feel even more of an idiot. Oh well

[The_Mark]

Well, you're not the only one
I'm really beginning to miss OFP scripting now.
gah.

[Epistolary Richard]

Just remember, kids, smilies are a powerful tool, but they can be used for both good and evil

Now returning to the matter in hand...

Also, shouldn't advancing the advice thread in question forward prevent her from popping up?

Unfortunately, I can't test anything for the next couple of weeks at least. If you've got an idea then run with it ~ otherwise I think Hanbaal might explode

[[cF]HanBaal]

The suspend during battle line stops the script being cancelled if a battle is played. This means you don't have to start the script again after every battle.

Nice. One less problem till perfection.

No, you don't need to have the advisor on.

And there goes 2 . I believe that with these 2 solved, we reach perfection and even the few unbelievers, nay-saying folks in our mod won't have the arguments to deny what most people already want

--------------

Unfortunately, I can't test anything for the next couple of weeks at least. If you've got an idea then run with it ~ otherwise I think Hanbaal might explode

2 WEEKS!!!

Since E.Richard is off for some time could you, Myrdraal or anyone capable, compile a new version with this new advisor/"reminder" (popping up every time we press any of the UI buttons or even also the selection of an army as you suggested) and with its "suspend" commands (to avoid its repetitiveness after the script is running)? I would be grateful a million times if you could do that for us

[The_Mark]

I didn't try refusing the advice - I assume if you do, she won't appear again.

She should, and CA had this in mind while doing this. AdviceSupressed-event should fire when player dismisses her, so we can keep her popping up until the player gets the message and starts the script