export_decr_character_trait isssues

[Sûlherokhh]

I'll be posting my findings regarding possible logical errors regarding certain traits and triggers in this thread.

Here is the first one (copy-paste from 1.1 file)

;------------------------------------------
Trigger temple_of_battle_GoodLeader_low_charisma
  WhenToTest CharacterTurnEnd

    Condition EndedInSettlement
          and RemainingMPPercentage = 100
          and SettlementBuildingExists >= temple_of_battle_temple
          and Trait NaturalCharisma < 3
          and Trait GoodLeader < 1

  Affects GoodLeader  1  Chance  2

;------------------------------------------
Trigger temple_of_battle_GoodLeader_med_charisma
  WhenToTest CharacterTurnEnd

    Condition EndedInSettlement
          and RemainingMPPercentage = 100
          and SettlementBuildingExists >= temple_of_battle_temple
          and Trait CharismaRating = 2
          and Trait GoodLeader < 1

  Affects GoodLeader  1  Chance  4

;------------------------------------------
Trigger temple_of_battle_GoodLeader_high_charisma
  WhenToTest CharacterTurnEnd

    Condition EndedInSettlement
          and RemainingMPPercentage = 100
          and SettlementBuildingExists >= temple_of_battle_temple
          and Trait NaturalCharisma > 4
          and Trait GoodLeader < 1

  Affects GoodLeader  1  Chance  8

Shouldn't it be ...

...

;------------------------------------------
Trigger temple_of_battle_GoodLeader_med_charisma
  WhenToTest CharacterTurnEnd

    Condition EndedInSettlement
          and RemainingMPPercentage = 100
          and SettlementBuildingExists >= temple_of_battle_temple
          and Trait NaturalCharisma > 2  ;;; instead of 'CharismaRating = 2'
          and Trait NaturalCharisma < 5  
          and Trait GoodLeader < 1

  Affects GoodLeader  1  Chance  4

...

?

[bovi]

No, it's good as is. CharismaRating is a derived trait from NaturalCharisma, as ICERating is (the latter from all three base stats). The reason why CharismaRating is used in the mid trigger you put forward is because it's then only one conditional instead of two.

Trigger Worthy_Of_Adoption_1_VnV_Trigger
  WhenToTest OfferedForAdoption

  Affects NaturalIntelligence  1  Chance  100
  Affects NaturalCharisma  1  Chance  100
  Affects NaturalEnergy  1  Chance  100
  Affects IntellectRating  1  Chance  100
  Affects CharismaRating  1  Chance  100
  Affects EnergyRating  1  Chance  100

Trigger Worthy_Of_Adoption_CharismaRating_VnV_Trigger
  WhenToTest OfferedForAdoption

    Condition Trait NaturalCharisma > 2

  Affects CharismaRating  1  Chance  100

Trigger Worthy_Of_Adoption_CharismaRating2_VnV_Trigger
  WhenToTest OfferedForAdoption

    Condition Trait NaturalCharisma > 4

  Affects CharismaRating  1  Chance  100

[Sûlherokhh]

Yay, of course. I should have done more than superficial research on CharismaRating beforehand. Thanks for clearing that up despite my apparent lack of thoroughness.