Logically, I would presume that Charisma and Vigour attributes matter the most. By simple observation you can conclude that Charisma affects leadership skills (command, morale) while Vigour determines (but there is always a random factor to it) combat abilities (hitpoints, morale). Also, most generals get much better with experience. AFAIK negative combat traits are rare.