export_descr_character_traits: Section 1.1.1 - Primary Triggers - ICE Rating - Cha...

[Twigvest]

Hi, I volunteered to help look at the export_descr_character_traits file in the recruitment thread today. I noticed people were complaining about having crappy generals, and how when they come of age they are Sharp/Uncharismatic/Lagarous. I believe I have found my first bug!

When determining the Intelligence/Charisma/Energy (ICE) when "CharacterComesOfAge" there are a couple of conditions in the initializations (as opposed to OfferedForMarriage or OfferedForAdoption etc, where there are no conditions).

Intitialize1 has:
"Condition Trait NaturalIntelligence < 1"
Which will be true for any fresh general. Then he is given +1 to each of Intelligence/Charisma/Energy as well as being assigned random Intelligence (rendering him likely Sharp in ICE)

But,
Intitialize2 has:
"Condition Trait NaturalCharisma < 1"
Which will always be false becase he was granted +1 Charisma in Intitialize1. Hence the Character is not granted the random Charisma/Energy (rendering him Uncharismatic/Lagarous). (Likely a copy paste bug, like I expected to find in places).

I suggest:
1) Remove the Conditions of Triggers:
random_birth_1_ICE_Trigger_Initialize1 (Condition Trait NaturalIntelligence < 1)
random_birth_1_ICE_Trigger_Initialize2 (Condition Trait NaturalCharisma < 1)

2) Change Condition of random_birth_1_ICE_Trigger_Initialize2 to something that will more likely be true, like:

Condition Trait NaturalCharisma = 1

I suspect these conditions exist because before this initialization, there are predefined characters who have specific ICE settings already. So fix 2 should be what is used.


I don't know if should bother, but I'll post this to the other forum too