The structures will significantly improve your generals over time if they sit there long enough (probability). They are fabulous boons to cities you plan to have governed by generals for long periods of time. They aren't worth bothing with in cities where generals will not spend much time.