Traits that are bugged in 1.2 with fixes. Part 1: Scarred, Farmer, Trader

[Jambo]

Hi, gregab25, I take it you didn't read that thread at twcenter then?

Here's a quote from that thread of one of the recent tests I did:

Ok, regarding the GeneralHPLostRatioinBattle and GeneralFoughtInCombat conditions, this is far more complicated than first expected. Or least it certainly seems to be.

To try to fully understand the function of these I set up a test based on the heroic_saviour ancillary. For my heroic saviour trait I had already removed the conditions WonBattle and not Routs and for the test I increased chances of being awarded the ancillary to 100% - so it looked like this:

Trigger trigger_heroic_saviour
WhenToTest PostBattle
Condition GeneralHPLostRatioInBattle "less than"= 0.2
and GeneralFoughtInCombat
and IsGeneral
AcquireAncillary heroic_saviour chance 100

For the test I changed the 7 ancillaries down from heroic saviour to have the same conditions but each with a varied HP condition. Inclusive of the heroic saviour these were "less than"= 0.2, 0.5, 0.8 and 1 and >=0.2, 0.5, 0.8 and 1.
So, armed with this I started a new Julii campaign and marched my leader to assault Segesta. When I assaulted the rebels I kept my leader out and away from the battle. I won the battle and upon returning to the campaign map I found I had received the first 7 of the 8 ancillaries (possibly a limit?). Repeating this battle changing the values to actual percentages rather than ratios didn't alter the outcome and neither did involving the general in the battle. It's fair to say I've reached a standstill and the only thing I could see governing these ancillaries seemed to be the chance of receiving them.

Take it from me, the stated change to the scarred trait doesn't work as you expect. I'm not sure whether the GeneralFoughtInCombat or the HP condition is bogus, but something isn't right.. The only way I can envisage some results is using the GeneralNumKillsInBattle condition. I havem't tested it in full, but at least this one forces the general to get involved for the traits to be awarded.

maybe someone can test and verify?

Cheers

Edited for the "less thans"