Traits that are bugged in 1.2 with fixes. Part 1: Scarred, Farmer, Trader

[therother]

Okay, putting ideas together.

Do the steps in the first 2 code boxes in this post, just forget about the 2nd level.

At the end of the Character file, add this:

;------------------------------------------
Trigger Remove DoubleCombat1 if = 1
    WhenToTest PostBattle

    Condition IsGeneral
          and Trait DoubleCombat1 = 1

    Affects AntiDoubleCombat1  1  Chance  100


;------------------------------------------
Trigger Add 1 to DoubleCombat1
    WhenToTest PostBattle

    Condition IsGeneral
          and Trait DoubleCombat1 = 0

    Affects DoubleCombat1  1  Chance  100


;------------------------------------------
Trigger Remove DoubleCombat1 aEoT
    WhenToTest CharacterTurnEnd

    Condition IsGeneral
          and Trait DoubleCombat1 = 1

    Affects AntiDoubleCombat1  1  Chance  100


;------------------------------------------
Trigger CharacterSelected remove trait
    WhenToTest CharacterSelected

    Condition CharacterIsLocal
          and IsGeneral
          and Trait DoubleCombat1 = 1

    Affects AntiDoubleCombat1  1  Chance  100

Then add:

          and Trait DoubleCombat1 = 0

as a condition for every battlefield trait.

Notes/Comments/Problems:

• This will stop the double traits for all battlemap battles (for AI and player), assuming that this type of battle is all that they have taken part in (i.e. no autocalc, or prebattle withdrawals).
• This will allow as many autocalcs as the player likes - as soon as you select your general to attack anyone else, the DoubleCombat1 trait is removed.
• There is still a problem for AI generals after a player-initiated autocalc, and multiple AI autocalcs involving the same AI general in one turn. For the 2nd, and all subsequence battles that turn, that AI general will receive no traits.
• Perhaps more annoyingly, if an AI General retreats from the initial attack, he will be given the DoubleCombat1 trait. Whilst the player's is expunged by the character select trigger, the AI's remains, meaning he will not get any traits if the player follows up and attacks on the same turn (I do this often). If only PreBattle worked!
• Similarly, it is possible that this could affect the player's general if he is attacked more than once during the AI's turns, and choses to withdraw or autocalc.
• …

What we need, assuming PreBattle is not implemented, is a condition that is always automatically triggered in between battles (even during AI turns), and can remove the DoubleCombait1 trait for all generals, irrespective of faction. I would even settle for a player activated one...

At the moment, the Code tags don't seem to be working correctly. Hopefully they will be fixed soon. In the meantime, you can quote the post to get the proper formatting.