Trader

Default Triggers:

;------------------------------------------
Trigger governing10
WhenToTest GovernorBuildingCompleted

Condition not SettlementBuildingFinished >= trader

Affects BadTrader 1 Chance 1

;------------------------------------------
Translation:

When a governor completes a building and the level of the building is NOT greater than or equal to the level of trader building the you have a 1% chance of receiving 1 point of BadTrader.

;------------------------------------------
Trigger governing11
WhenToTest GovernorBuildingCompleted

Condition SettlementBuildingFinished >= trader

Affects GoodTrader 1 Chance 50

;------------------------------------------
Translation:

When a governor completes a building and the level of the building is greater than or equal to the level of the trader you have a 50% chance of gaining one point in GoodTrader.

;------------------------------------------
Trigger governing11b
WhenToTest GovernorBuildingCompleted

Condition SettlementBuildingFinished >= port

Affects GoodTrader 1 Chance 80

;------------------------------------------
Translation:

When a governor completes a building and the level of the building is greater than or equal to the level of the port you have a 80% chance of gaining one point in GoodTrader.

;------------------------------------------
Trigger governing11c
WhenToTest GovernorBuildingCompleted

Condition SettlementBuildingFinished >= roads

Affects GoodTrader 1 Chance 80

;------------------------------------------
Translation

When a governor completes a building and the level of the building is greater than or equal to the level of roads you have an 80% chance of gaining one point in GoodTrader.

Why they are bugged:

Again its those damn greater than signs being reversed!

How to Fix:

Make these corrections to the triggers:

;------------------------------------------
Trigger governing10
WhenToTest GovernorBuildingCompleted

Condition SettlementBuildingFinished > trader

Affects BadTrader 1 Chance 1

;------------------------------------------
Here I removed the NOT from the condition. So if the building IS greater than the trader you have a chance for BadTrader. Or you could leave the NOT in the condition and make the sign a less than or eqaul to sign.

;------------------------------------------
Trigger governing11
WhenToTest GovernorBuildingCompleted

Condition not SettlementBuildingFinished > trader

Affects GoodTrader 1 Chance 50

;------------------------------------------
Here i added the NOT to the condition and removed the equal sign so that now if the building finished is NOT a level greated than the level of trader you have a chance at GoodTrader.

;------------------------------------------
Trigger governing11b
WhenToTest GovernorBuildingCompleted

Condition not SettlementBuildingFinished > port

Affects GoodTrader 1 Chance 80

;------------------------------------------
Again, I added the NOT and removed the EQUAL SIGN from the condition so that now if the building is not a level greater than the level of the port you have a chance at GoodTrader. Again, you could also try just reversing the sign in the orginal to a less than or equal sign.

;------------------------------------------
Trigger governing11c
WhenToTest GovernorBuildingCompleted

Condition not SettlementBuildingFinished > roads

Affects GoodTrader 1 Chance 80

;------------------------------------------
Same as above. Added NOT and removed EQUAL.

NOTE:

For all the above fixes I added a NOT or removed the NOT depending on which ever the condition did not have. I also removed all the equal signs from the arguments. You could just as easily leave the NOT conditions as they were and instead reversed the signs from greater than to less than signs. Ultimately the effect is the same I believe.

I believe the above corrections make the traits behave as CA intended them to. These are not intended to be mods. Again however, CA would have to comment for me to be 100% sure.

Also, the Thresholds on gaining a rank in GoodTrader are the highest in the game I believe. They are 24, 48, and 60 for each rank respectively. So they are still very difficult to receive.