Traits that are bugged in 1.2 with fixes. Part 1: Scarred, Farmer, Trader

[screwtype]

Nice piece of detective work. I 've only played through half a campaign with 1.2 and I already have scarred, farmer and bad trader traits all over the place!

Thanks I will try those changes. BTW have you tested your theories to see if they work?

[Jambo]

Interesting.

But I'm not sure that the scarred trait, amongst others, is so easily fixed as originally thought. You might want to pop over to this thread in twcenter for some more information on the various traits that involve HPs and Generals in battle:

http://www.twcenter.net/forums/index...howtopic=21798

The problem seems to be the general being awarded these traits when not getting involved in the battle. This is irrespective of which way the ratio is annotated. Whether this means the HPs condition isn't working or more likely, the GeneralFoughtInBattle condition, i'm not entirely sure. However, it appears this can be somewhat remedied by the using the GeneralNumKillsInBattle condition instead.

Cheers

[Simetrical]

Are you sure that "farm" and "trader" in the SettlementBuildingFinished compare the level of existing farms/traders to the newly-finished building? I assumed that "Condition SettlementBuildingFinished >= farms" returned true if, when the trigger was checked, the settlement in question had any farm, no matter what building was finished. In other words, if you build something when a farm exists in the settlement, you get +1 to GoodFarmer (which, as you noticed, really isn't a lot), while if you build anything before a farm, you risk getting BadFarmer. In this case, the current sign makes sense.

I don't know which of us is right. Yours makes more sense, I must agree. It should be fairly simple to test.

-Simetrical