Traits that are bugged in 1.2 with fixes. Part 1: Scarred, Farmer, Trader

[Jambo]

Hi, gregab25, I take it you didn't read that thread at twcenter then?

Here's a quote from that thread of one of the recent tests I did:

Ok, regarding the GeneralHPLostRatioinBattle and GeneralFoughtInCombat conditions, this is far more complicated than first expected. Or least it certainly seems to be.

To try to fully understand the function of these I set up a test based on the heroic_saviour ancillary. For my heroic saviour trait I had already removed the conditions WonBattle and not Routs and for the test I increased chances of being awarded the ancillary to 100% - so it looked like this:

Trigger trigger_heroic_saviour
WhenToTest PostBattle
Condition GeneralHPLostRatioInBattle "less than"= 0.2
and GeneralFoughtInCombat
and IsGeneral
AcquireAncillary heroic_saviour chance 100

For the test I changed the 7 ancillaries down from heroic saviour to have the same conditions but each with a varied HP condition. Inclusive of the heroic saviour these were "less than"= 0.2, 0.5, 0.8 and 1 and >=0.2, 0.5, 0.8 and 1.
So, armed with this I started a new Julii campaign and marched my leader to assault Segesta. When I assaulted the rebels I kept my leader out and away from the battle. I won the battle and upon returning to the campaign map I found I had received the first 7 of the 8 ancillaries (possibly a limit?). Repeating this battle changing the values to actual percentages rather than ratios didn't alter the outcome and neither did involving the general in the battle. It's fair to say I've reached a standstill and the only thing I could see governing these ancillaries seemed to be the chance of receiving them.

Take it from me, the stated change to the scarred trait doesn't work as you expect. I'm not sure whether the GeneralFoughtInCombat or the HP condition is bogus, but something isn't right.. The only way I can envisage some results is using the GeneralNumKillsInBattle condition. I havem't tested it in full, but at least this one forces the general to get involved for the traits to be awarded.

maybe someone can test and verify?

Cheers

Edited for the "less thans"

[gregab25]

Hi Jambo, I think I know why that wasn't working for you.

First of all I can see that by doing the math that ancilliary is going to be very hard to receive.

Second, i have found that using "less than"= does not work for some reason as i stated above. Maybe it is like html code in some way. To be honest i don't know the reason, but i know it doesn't work from all the tests i ran trying to figure out farming. You can make the same argument as a < = to though by using the condition "NOT" though.

Third, lets clarify that "GeneralHPLostRatioInBattle" is the general's HP at the end of battle divided by his HP's at the start of Battle.

Let's take a look. Here is the trigger you were using.

Trigger trigger_heroic_saviour
WhenToTest PostBattle
Condition GeneralHPLostRatioInBattle "less than"= 0.2
and GeneralFoughtInCombat
and IsGeneral
AcquireAncillary heroic_saviour chance 100

Your argument says: After a battle if a General has less than or equal to 20% of his hit points remaining and he fought in combat then you have a 100% chance of receiving the ancillary Heroic Saviour.

I believe, correct me if i am wrong b/c i am not sure about this, that the default HP's for a General's Bodyguard of Heavy Cavalry is 2HP. So, it would be mathematically impossible to receive that ancillary with a default general, because to go below 20% your general would have to be dead.

IE:

2/2 = 100% - is not below the 20% requirement.
1/2 = 50% - is not below the 20% requirement.
0/2 = 0% - meets the requirement but your general is dead.

However, it is my understanding that a general that is also the faction leader receives 5 more HP for a total of 7HP. So it would be mathematically possible for him to receive the ancillary using your arguement if he had only 1HP remaing of his 7HP. 1/7 = 14%. But that still is a very low probability.

I have not investigated any of the ancilliaries yet or possible bugs with them. So I am not really familiar with the Heroic Saviour Ancilliary, but he sounds good. And, looking at the math, it may be that CA intended for it to a) only your faction leader or faction heir to be able to receive it, and b) the mathematical probability even with a faction leader or heir is very low.

But As i said above i believe the < = argument to be bugged. so i would still switch this trigger to read like this no matter what other changes you should make.

----------------------------------------------------
Trigger trigger_heroic_saviour
WhenToTest PostBattle
Condition Not GeneralHPLostRatioInBattle > 0.2
and GeneralFoughtInCombat
and IsGeneral
AcquireAncillary heroic_saviour chance 100
----------------------------------------------------

All i did was change this:

Condition GeneralHPLostRatioInBattle "less than"= 0.2

To this:

Condition Not GeneralHPLostRatioInBattle > 0.2

If you think about it, it is still the same arguemnt just said in a different way.
And it avoids using the < = to sign which I believe is bugged or non functional.

Now if you are dead set on getting the ancilliary Heroic Saviour, you have the option to change several things in the trigger to get it.

For Example:

Ex. 1:
----------------------------------------------------
Trigger trigger_heroic_saviour
WhenToTest PostBattle
Condition GeneralHPLostRatioInBattle > 0.2
and GeneralFoughtInCombat
and IsGeneral
AcquireAncillary heroic_saviour chance 100
----------------------------------------------------

Here I removed the word "Not" from the condition so that now at the end of battle if my general has more than 20% of his HP's remaining he has a 100% chance of receiving the ancilliary. Very good Probability.

Ex. 2:
----------------------------------------------------
Trigger trigger_heroic_saviour
WhenToTest PostBattle
Condition Not GeneralHPLostRatioInBattle > 0.8
and GeneralFoughtInCombat
and IsGeneral
AcquireAncillary heroic_saviour chance 100
----------------------------------------------------

Here I simply changed the value for the qualifier from 0.2 to 0.8. Now if the general does NOT have more than 80% of his HP's remaining he will qualify. Good probability with your general having to fight as the 2nd condition.

Anyways, there are several ways to get that ancilliary if you want him. I hope I have shown you why you were having such a hard time getting the ancillary and ways to fix it. For some generals it was just mathematically impossible and extremely hard for others.

Also thanks for bringing this to my attention as it seems there are some bugs in the ancillary triggers too that I want to look into.

[tai4ji2x]

also: could you post a more current version of your farmer/trader fixes?

[hrvojej]

Second, i have found that using "less than"= does not work for some reason as i stated above. Maybe it is like html code in some way. To be honest i don't know the reason, but i know it doesn't work from all the tests i ran trying to figure out farming. You can make the same argument as a < = to though by using the condition "NOT" though.

Well, if this is indeed true, then the character traits file needs some serious rewriting, especially if the >= doesn't work either.