Traits that are bugged in 1.2 with fixes. Part 1: Scarred, Farmer, Trader

[tai4ji2x]

i'm actually not sure if that's what CA intended either... for the logic i'm trying to explain, here's a excerpt from the campfreddie fix's readme (http://www.twcenter.net/forums/index...howtopic=21549 and http://www.twcenter.net/downloads/db/?mod=359)

The trait triggers for scarred and berserk traits use the GeneralHPLostRatioinBattle query.

They were supposed to give you a 30% chance of getting scarred traits if your general lost >30% of his hitpoints in a battle - but the developers messed it up.

GeneralHPLostRatioinBattle is supposed to find the ratio of hitpoints lost by your general, from 0 (full health) to 1 (dead).

In v1.0 and v1.1, the developers mistakenly used a percentage figure (>30%), which meant that the trigger neverworked (your general would have to be 30x dead to give you the trait).

In v1.2 they set it to a ratio instead of a percentage (30% = 0.3 ratio). However, this revealed that the trait trigger GeneralHPLostRatioinBattle was bugged. All generals would get scarred in battle, even if they didn't get involved in the fight!

I discovered that the query GeneralHPLostRatioinBattle was actually giving you the ratio of hitpoints remaining and NOT the ratio of hitpoints lost. Therefore, I've changed the triggers to GeneralHPLostRatioinBattle "less than" 0.7, so that the trait is gained when you have "less than" 70% of your hitpoints remaining at the end of the battle (i.e. you've lost more than 30%)

This reflects what was obviously the original intention of the developers.

The trait is still a little bugged, and seems to be tested for multiple times in one battle. If you really get your general beaten up, you can still jump to hideously scarred in one go (I managed to do this once). That shouldn't happen often though, and it'll never happen if your general avoids getting beaten up.

though i agree with your feeling that the trait should be much harder to get