Traits that are bugged in 1.2 with fixes. Part 1: Scarred, Farmer, Trader

**player1** · 03-01-2005, 09:04

What are default general hit points anyway?

**Jambo** · 03-01-2005, 11:17

player 1, are you the guy from the civ forums that made the patch suggestion mod? Anyway, I think the General by default has 6 hitpoints. Edit: actually campfreddie might be right.

As well as the battlescarred, your fixes will also have to be applied to berserker trigger and the shieldbearer and heroic saviour ancillaries.

**player1** · 03-01-2005, 12:03

Originally Posted by Jambo

player 1, are you the guy from the civ forums that made the patch suggestion mod?

yes

**therother** · 03-01-2005, 15:05

Okay, using the rules (in this order) that I think Zrave is suggesting above:

If (bug, Fix) = (1,2), then (bug, Fix) reset to (0,0)
Parse battlemap triggers - no trait if Bug = 1
If Bug = 1 then Fix = 2
If Bug = 0, then Bug = 1)

And (1,2) is the maximum level for (Bug, Fix)...

If so, then these are the outcomes I expect from a few senarios:

If this is accurate, then I'm much happier. Although it is still penalising the AI, as the AI will normally fight far more A/Cs than the player. My preference, given the current situation with the AI, would be to penalise the player in situations such as this.

**player1** · 03-01-2005, 17:25

Consdering that scarred is buggy for autocalc, maybe something like this could be a quick-patch

;------------------------------------------
Trigger battle1
WhenToTest PostBattle

Condition GeneralHPLostRatioinBattle < 0.7
and GeneralHPLostRatioinBattle > 0

Affects BattleScarred 1 Chance 30
Affects Brave 1 Chance 15

;------------------------------------------

Added GeneralHPLostRatioinBattle > 0 prevents getting Scarred in autocalc battles in which general didn't got injured at all. Same condition for manual cointrolled battles is not problem considering that general would be dead, for =0 anyway.

**player1** · 03-01-2005, 18:39

Actually, when I think about it GeneralHPLostRatioinBattle > 0.15 is probably the best option.

For autocalc that means generals which lost more then 1hp.

7hp*0.15=1.05
9hp*0.15=1.35
11hp*0.15=1.65
13hp*0.15=1.95

That should leave enough room for autocalc to award scarred not to often.

For manual battles that just means that general which have 1hp left won't get checked for scarred trait (no big deal).

**Zrave** · 03-01-2005, 19:08

I ran a test of the scarred bug player1 has just described and he's right on the money. So much for the theory that the double trigger bug was due to a "battle" pass and a "strat" pass, the autocalc engine uses its own ruleset.

My test was as such:

trait1 -> GeneralHPLostRatioinBattle > 0

trait2 -> GeneralHPLostRatioinBattle < 1

A tactical battle without general engaging gave me two points of trait1 and no trait2. the same battle with autocalc gave me no trait1 and one point of trait2. This means there was no engagement, because for only trait2 to be awarded the ratio had to be exactly 0, which by the tactical ruleset would mean dead.

As for fixing it, how about this:

;------------------------------------------
Trigger scarred1
WhenToTest PostBattle

Condition GeneralHPLostRatioinBattle < 0.3
and GeneralNumKillsInBattle > 6

Affects Battlescarred 1 Chance 100

;------------------------------------------
Trigger scarred2
WhenToTest PostBattle

Condition GeneralHPLostRatioinBattle > 0.7
and GeneralNumKillsInBattle > 6

Affects Battlescarred 1 Chance 100