Traits that are bugged in 1.2 with fixes. Part 1: Scarred, Farmer, Trader

[Zrave]

player1, my second fix uses a different condition - it represents what percentage of the general's unit has died. I think it is a decent approximation of how much damage the general himself has sustained, but is not bugged like HPLostRatio is.

I understand your concern for trying to keep changes small, and I ordinarily would subscribe to that. However, since I am working on this for the CVP (a mod) I want to get the best approximation of what I interpret the concept to be, hopefully maximizing fun/gameplay in the process. For the purposes of keeping changes small, I think yours is the best and perhaps only solution.

I liked therother's suggestion of doing away with HPLostRatio entirely, since its hard to implement something so fickle. I think the combination of both conditions will rarely produce an odd result, but I wonder if number of kills is even necessary?

Does the general have better defensive stats than a regular man in his unit? If not, it should be possible to calculate at what percentage he should have been severely wounded.

[Pode]

I believe generals have the same stats but more hit points, although I'd be hard pressed to support that claim.

[player1]

As far as I understand generals have +5hp compared to the bodyguard unit.

So 7hp default, 15hp if scarface, 1hp if very, very ill.

[player1]

Nevermind, I just realized thta it needs to be 80% and not 0.8

[Zrave]

CVP 1.2 was just released with fixes for all the bugs discussed here.