Research: Fixing the trait bugs

[therother]

Have I understood it correctly that Coward with the old fix is impossible?

As I understand it, it will be impossible with Camp Freddie's fix if you fight all battles on the battlemap, as the condition GeneralFoughtInCombat is always true. However, it should be possible to get it from an autocalc battle.

If anybody is interested I made fixed version of coward and scarred trait at Scarface thread at twcenter

Any chance you could compile the changes made into one post?

[player1]

Ok, I'll try.
It's pretty much slightly modified version of Camp Freddie fixes to export_descr_character_traits.txt

these are modified battle1 triggers:

;------------------------------------------
Trigger battle1
    WhenToTest PostBattle

    Condition GeneralHPLostRatioinBattle < 0.7

    Affects BattleScarred  1  Chance  30 
    Affects Brave  1  Chance  15 

;------------------------------------------
Trigger battle1b
    WhenToTest PostBattle

    Condition GeneralHPLostRatioinBattle < 0.7
          and Trait Berserker >= 1

    Affects Berserker  1  Chance  30 

;------------------------------------------
Trigger battle1R
    WhenToTest PostBattle

    Condition GeneralHPLostRatioinBattle < 0.7
          and CultureType roman

;    Affects BattleScarred  1  Chance  30 
    Affects RomanHero  1  Chance  15 

;------------------------------------------

and modified battle4 trigger:

;------------------------------------------
Trigger battle4
    WhenToTest PostBattle

    Condition GeneralNumKillsInBattle = 0
          and PercentageEnemyKilled > 0

    Affects Coward  1  Chance  10 

;------------------------------------------

[player1]

quote the message if you wanna see correct formating

[Bob the Insane]

For the coward thing I am using:

;------------------------------------------

Removed due to being stupid...  ~D   

;------------------------------------------

If I follow this correct this is triggered if the general was on the battlefield but was withdrawn (GeneralFoughtInCombat returns false) and none of the enemy was killed...

From what I can see you should only get the coward trait when you go to the battlemap, if you withdraw from the strategic map a lot you should get IndecisiveAttacker instead. Is this what people see?

[player1]

You need to realise that after some testing I'm confident to say that GeneralFoughtInCombat is always true in battle.

But, if you do autocalc, it would be only true if general didn't actually fighted.
So GeneralFoughtInCombat is bugged. Use some other trigger instead.

Also, what you use (with added not), will trigger coward when doing autocalc and some enemies get killed, but not by general.

Better replace it with GeneralNumKillsInBattle = 0, so it works for both autocalc and manual battle.

[Bob the Insane]

player1 - I understand where you are coming from and I understand the problems you have pointed out... (I have removed the code I suuggested to avoid confusng people)...

But, one thing I noted with the example you provide, it will not trigger coward for simply withdrawing from the battlefield immediately (on the battlemap). Where GeneralNumKillsInBattle = 0 and PercentageEnemyKilled = 0 (I presume)... Was this intentional?

[player1]

The problem is that if you leave that, then you could get coward trait when enemy withraws right from start (and not just you).

[Camp Freddie]

But, one thing I noted with the example you provide, it will not trigger coward for simply withdrawing from the battlefield immediately (on the battlemap). Where GeneralNumKillsInBattle = 0 and PercentageEnemyKilled = 0 (I presume)... Was this intentional?

Player1's fixes to my attempt at solving the coward bug seem to be the best option. Generalfoughtincombat seems to be totally buggered. This could be affecting the Heroic Saviour ancilliary too, which should be changed to GeneralNumKillsInBattle > 0.

To answer your question, it will not trigger if you withdraw, BUT that isn't what the coward trait is about.
There's another trait (indecisive attacker) and 3 triggers which cover withdrawing before combat (100% chance when you are the attacker, 50% chance when odds are 0.8-1.5 and a 50% chance for a 2-step increase when odds >3). It has huge thresholds though (8, 16, 32) and has goodcommander and goodattacker as antitraits, so it's hardly ever seen.
Strangely, if odds are 1.5-3 and you aren't attacking, it's safe to withdraw - another trait glitch!
Therefore, in Trigger V0200, the > 3 should be reduced to > 1.5. If you want coward traits to be added, then put "coward 1 chance 50" in Trigger V0200, which would now fire when odds >1.5 and you withdraw. You could put "coward 1 chance 10" in Trigger V0190 as well, if you want to really persecute generals who avoid battle when they have a good chance of winning!
The only problem is that I don't know how often the AI general withdraws. If he withdraws a lot (he did in MTW) then he could be heavily penalised by coward traits. That might even be the reason why "indecisive attacker" has such high thresholds.