BUG-FIXER, an unofficial patch for Rome: Total War

[player1]

Ok, by looking some old indexed threads, I just realised that Good/Bad Conspirator trait is a bit buggy.

Newly created spies sometimes get it. Good.
After some missions spies could get it. Good.

But, it seems that after sabotage missions assassins should get it too.

Look these lines:

;------------------------------------------
Trigger agents13
    WhenToTest SabotageMission

    Condition not MissionSucceeded

    Affects BadConspirator  1  Chance  100 

;------------------------------------------
Trigger agents14
    WhenToTest SabotageMission

    Condition MissionSucceeded

    Affects GoodConspirator  1  Chance  100 

;------------------------------------------
Trigger agents15
    WhenToTest SabotageMission

    Condition MissionSucceeded

    Affects GoodConspirator  2  Chance  50 

;------------------------------------------
Trigger agents16
    WhenToTest SabotageMission

    Condition MissionSucceeded

    Affects GoodConspirator  3  Chance  25

And there is a bug, since Conspirator trait is reserved for spies only, making it impossible to gain by sabotage.


So:

;------------------------------------------
Trait GoodConspirator
    Characters spy
    AntiTraits BadConspirator

should be changed to:

;------------------------------------------
Trait GoodConspirator
    Characters all
    AntiTraits BadConspirator

Same should be done to BadConspirator trait too.


I changed it to all, since I don't think it would work if I add two types of agents in Character line. Should not be a problem since no other type gets checked for Conspirator.


Also, if you look closely agents14-16 triggers you'll see that you would get unrealistic amount of experience for every mission, since all 3 traits get checked (2.75 poitns per mission, on average). Not to mention that threashold tops at 8. If we compare how all other agent traits work, it's obvious that only agents14 trigger should be used while others should be deleted or outcommented.


What do others think?