Erm... Come on CP, surely you know the glitch where GeneralHPLostRatioinBattle returns opposite values for manual and autocalc battles. Even at >0.6 it'll trigger when you don't use your general in a manual battle, since it actually acts as GeneralHP*Remaining*RatioinBattle.
Since players usually manual battle, they would get loads of scarred traits even when they kept their general safe. The double combat trait glitch made it worse and the lack of 'and culturetype not roman' in one of the triggers meant that after Roman manual battles, the scarred trait would be checked 4 times at 30% chance when the general was uninjured. Your suggestion fixes this a bit, but unfortunately it still won't work fully.
We couldn't work out a way of distinguishing autocalc from manual battles in the trait triggers, so we had to abandon the use of GeneralHPLostRatioinBattle.
In our mods, we've had to use generalbodyguardpercentagekilled instead of GeneralHPLostRatioinBattle since that trigger works for both autocalc and manual.
Oooh, P1 beat me to it! Still, P1, shouldn't that be "less than" for manual and "greater than" for autoresolve?
CP's fix doesn't solve the problem, it just reduces the effect because "chance" has been changed to 10% from 30% and the non-roman trigger now only applies to non-romans.
This is fine for autoresolve (triggers when over 60% of HP is lost) but to get it to work in manual battles you'd need the following:
_____________________________________
Trigger battle1
WhenToTest PostBattle
Condition GeneralHPLostRatioinBattle < 0.4
and not CultureType roman
Affects BattleScarred 1 Chance 10
Affects Brave 1 Chance 15
____________________________________
Also, the double combat bug trait (introduced in v1.2) must be fixed somehow.
Bookmarks