But what if you have a ten star general who also has a 'good attacker' trait? In the battle map does it count as 12 stars when you attack?

though it's not like it matters that much...