has the guy still got the old faction leader trait in descr_strat?... also the faction heir/leader triggers have to work together... perhaps make a new faction heir trait as well unless you can't be bothered but from a quick glance that looks fine....