The rules are simple.
If governor descreases city income while in city and has no other useful benefits (like better public order), then don't have him in the city, use him like cavalry or if having good command as general.