Replenish unit script question

[miska]

Here is what I have in mind. I would like the game to replenish a general's units whenever he ends his turn in a settlement. Here is what I have so far. I can't get it to work. I only tried with one general, but of course it would be preferable if the script checked all generals for all factions.

script
	declare_counter loop
	set_counter loop 0
	
		monitor_event FactionTurnStart FactionIsLocal TrueCondition
			
			monitor_conditions EndedInSettlement Quintus
			replenish_units Quintus
			end_monitor
		
		end_monitor
				
	while I_CompareCounter loop = 0
	end_while

end_script

I checked the the overall script works. If I just ask it to reposition quintus, for example, without checking EndedInSettlement, it works.

[Mengde]

i really don't know if it would effect it but maybe if you aligned replenish units one more tab in.....

monitor_conditions EndedInSettlement Quintus
. replenish_units Quintus
end_monitor

like so? again just giving idea's as i am just a beginning modder.....

[alpaca]

You can't have a monitor inside another one. You could just use the Condition monitor anyways and add "and FactionIsLocal" to it.
EndedInSettlement doesn't take a parameter, either, you can't check the character name anyhow afaik.

[Epistolary Richard]

Yep, our inability to check the character's name for anything prevents us from having quite a few neat features

[Myrddraal]

You can get rid of one of the monitors, either by using an 'and' as was suggested, or by using an 'if'. Also, I think that this is how you use EndedInSettlement:

script
declare_counter loop
set_counter loop 0
	
		monitor_event CharacterTurnStart Quintus		
			and EndedInSettlement 
			replenish_units Quintus		
		end_monitor
				
	while I_CompareCounter loop = 0
	end_while

end_script

[miska]

Myyrdal,

Thanks for your suggestion. Interesting behaviour with your version of the script. If Quintus is NOT in a settlement, his units get replenished. If he IS in a settlement and needs replenishment, the game CTDs. I'll try a couple more things.