ATV-TW: a trait (and future ancillary) validator for RTW/M2TW

**Tamur** · 10-23-2007, 13:30

hi all,

I received a PM today letting me know about the new posts in this thread. Let me dig around a bit to check on that source code. I certainly hope it has survived the changes of job and location in the past year

Will post up again once I know something...

**Tamur** · 10-23-2007, 13:42

Well that was easy...

ATVTW-source.zip (370K)

This includes bin and obj folders from the last build (a long while back). Feel free to nuke them.

And don't expect anything fancy. I did comment fairly well as I was writing it, hopefully that's helpful. The main parser is just a gigantic set of conditionals so it's fairly easy to sift through once you've found the right spot.

Let me know if there are confusing parts, and good luck!

**Squid** · 11-01-2007, 18:54

Originally Posted by Tamur

Well that was easy...

This includes bin and obj folders from the last build (a long while back). Feel free to nuke them.

And don't expect anything fancy. I did comment fairly well as I was writing it, hopefully that's helpful. The main parser is just a gigantic set of conditionals so it's fairly easy to sift through once you've found the right spot.

Let me know if there are confusing parts, and good luck!

Thanks,

Once I had a look around the code, it's not very difficult to follow what you were doing, your commenting really helped.

Here's a new version of ATV-TW

<<Removed link as this is an outdated version, see this post for the current version>>

This version has the following fixes and improvements:

Fixes:
- Fixed Subterfuge not being recognized as a valid attribute
- Fixed Bribery not being recognized as a valid attribute
- Fixed crash with Condition I_BattleSettlementFortificationLevel
- Fixed last trigger in export_description_ancillaries.txt not being checked or displayed on the Ancillary Trigger tab
- Fixed last trigger in export_description_character_traits not being checked or displayed on the Trait Triggers tab
- Fixed incorrect error message if an ancillary has an invalid attribute in an effects line

Improvements:
- Triggers that assign traits in export_description_ancillaries, now appear in the trait trigger tab
- Changed the icon the vanilla icon

The next release will have improved condition checking included in it.

If you find any errors, please PM me or post here so I can include a fix in the next release.

**Tamur** · 11-01-2007, 19:22

hiya Squid, thanks for taking the reins on this! Glad to hear it wasn't too much fo a nightmare to dig through. I'll be interested to watch the progress.

I'm having some strange non-existent object errors when browsing ancillary triggers, but that may simply be me using an old file I had lying about.

**Makanyane** · 11-01-2007, 19:54

Thanks both for getting this moving again.

New version is working for me - old one gave up on my rather extensively mangled file, though I admit to not re-trying it since working more on file.

For triggers its throwing this out

Trigger trigger_slayer4
WhenToTest PostBattle

Condition BattleGeneralKilled
and not GeneralFoughtFaction slave

Affects slayergeneral 1 Chance 100

as wrong though I thought it was working in practice - did check it at one stage and think it triggers even if 'general' is actually a captain not family member but I think it works. It also doesn't like WithdrawsBeforeBattle on End Turn check but have noticed that vanilla uses I_WithdrawsBeforeBattle on "WhenToTest PreBattleWithdrawal"
so might switch to that arrangement instead anyway.

Other thing I put in deliberately to see if it would check is a duplicated trigger name, it doesn't seem to catch that...

**Squid** · 11-01-2007, 20:15

Originally Posted by Makanyane

Thanks both for getting this moving again.

New version is working for me - old one gave up on my rather extensively mangled file, though I admit to not re-trying it since working more on file.

For triggers its throwing this out

Trigger trigger_slayer4
WhenToTest PostBattle

Condition BattleGeneralKilled
and not GeneralFoughtFaction slave

Affects slayergeneral 1 Chance 100

as wrong though I thought it was working in practice - did check it at one stage and think it triggers even if 'general' is actually a captain not family member but I think it works. It also doesn't like WithdrawsBeforeBattle
which again I'm fairly sure is working

Some method of skipping past trigger conditions it doesn't like might help, can't seem to get it to scan past them without altering them at moment.

Neither of those conditions is in the docudemon files. For the WithdrawsBeforeBattle, there is an I_WithdrawsBeforeBattle condition though, is that the one you're looking for?

If you, or someone else, can confirm that those condition are actually accepted by the engine and work in game I'll include them in the next patch.

EDIT: There is one bug I just found, if traits have not been parsed and you try to parse the ancillaries and you have traits assigned in export_descr_ancillaries.txt it will cause the program to crash. I'm going to fix the bug and release a new version.

**Bardo** · 11-05-2007, 00:41

Thank you for this new version. It was a bit annoying when I needed to quote out all the entries with subterfuge or bribery...
I'll be looking forward the next release.