"Marian" Reforms

[BozosLiveHere]

For the last couple of days Ive been quite busy with these reforms, as they weren't happening for me. I was gonna start a thread about it, but now you have.

I have to admit I use BI and Ive changed a few things (small bugfixes and I removed the popularis-requirement for the reformator-general (I didnt get a popularis consul ))

I had all the requirements >399 turns, >44 provinces, enough latifundia, but no reform for at least 10 turns. So I tried getting them by manipulating the script. The only way for me to get reforms was to change the trigger to:

Spoiler Alert, click show to read: 

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; MARIAN TRIGGER

;Unconditional Reforms
monitor_event FactionTurnEnd FactionType seleucid
and I_CompareCounter Romanii_Reform = 1
and I_NumberOfSettlements seleucid > 89

	set_counter Romanii_Reform 2
        terminate_monitor

end_monitor

;Conditional Reforms
monitor_event FactionTurnEnd FactionType seleucid
and I_CompareCounter Romanii_Reform = 1
and I_TurnNumber > 399

set_counter Romanii_Reform 2
terminate_monitor

end_monitor

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; IMPERIAL TRIGGER

adding

Spoiler Alert, click show to read: 

and BattlesFought > 1

was already enough for the reforms not to happen.

So BattlesFought is bugged now? Gah!

Furthermore I came across a number of errors (what I think are errors) in the script (bold: my suggestions):

for every city:

monitor_event SettlementTurnStart SettlementName Ak-Ink
and I_CompareCounter Romani_Reform = 0
and not SettlementBuildingExists = romani1
and I_SettlementOwner Ak_Ink = seleucid

console_command create_building Ak_Ink "romani1"

end_monitor

and I_CompareCounter Romanii_Reform = 0

Already noticed and fixed for .81.

Imperial trigger:

monitor_event FactionTurnEnd FactionType seleucid
and I_CompareCounter Romani > 54
and I_TurnNumber > 499
and I_NumberOfSettlements seleucid > 89
and BattlesFought > 399
and I_CompareCounter Romanii_Reform = 2
and I_CompareCounter AugustanReformatorCounter = 1

	set_counter Reform 3

end_monitor

set_counter Romanii_Reform = 3 and maybe a terminate monitor, like in other triggers.

Thanks for the heads-up.

Detect current reform:

Spoiler Alert, click show to read: 

;Detect current reform
monitor_event SettlementTurnEnd SettlementBuildingExists = romani2
and not SettlementBuildingExists = romani3
and not SettlementBuildingExists = romani4
and FactionType seleucid

	set_counter Romanii_Reform 1
	terminate_monitor

end_monitor

monitor_event SettlementTurnEnd and SettlementBuildingExists = romani3
and not SettlementBuildingExists = romani4
and FactionType seleucid

	set_counter Romanii_Reform 2
	terminate_monitor

end_monitor

monitor_event SettlementTurnEnd SettlementBuildingExists = romani4
and FactionType seleucid

	set_counter Romanii_Reform 3
	terminate_monitor

end_monitor

The first and third entry dont have and between SettlementTurnEnd and SettlementBuildingExists, the second one does.

The second one is wrong, there should be no and there.