Scripting problems

[Makanyane]

Next question; see I told you I'd be back....

trying to use SettlementName function with double barrelled names, had heard there was a problem with that before, looked at LotR's script (I'm going to have to apologise to their script writer for cribbing)

they use equivalent of
monitor_event SettlementTurnStart SettlementName Fir·Reneh

with dot instead of underscore, I can't persuade that or any alternative to work for Settlement internal name Fir_Reneh, though the underscored version works in other instances like
if I_SettlementOwner Akna_Keil = ostrogoths

the double name is definitely the only thing breaking it, if I switch to a single city name the event triggers.

so does anyone know is Alex different from BI in this? And any ideas of solutions, hopefully other than re-naming half my regions in 5 different campaigns?!

[Atilius]

Here's some code I wrote using vanilla RTW settlement names; this one is for Narbo Martius:

monitor_event GeneralCaptureSettlement region_id=43
    console_command set_building_health Narbo_Martius core_building 0
    console_command set_building_health Narbo_Martius barracks 0
    console_command set_building_health Narbo_Martius equestrian 0
    console_command set_building_health Narbo_Martius missiles 0
end_monitor

Doing the region_id comparison will work as long as your event exports the region ID. SettlementTurnStart and SettlementTurnEnd both do, so this ought to work for you. The region ID is displayed when you use show_cursorstat, so it's pretty easy to find.

[Makanyane]

That works thanks Atilius

Looks like the region ID is numbered by game starting at top left corner - not according to descr_regions anyway, which means if you added new region to map whilst working on script you'd break the intended effect! Guess this is good lesson not to use underscored internal names.

[Monkwarrior]

Sorry for "kidnapping" your thread a little, Mak but I have a doubt about scripting.

I remember that somebody, somewhere, told that the condition FactionBuildingExists doesn't work, but I've been unable to find the post where it was told.

Can anybody confirm this point?

[Makanyane]

Sorry for "kidnapping" your thread a little, Mak but I have a doubt about scripting.

I remember that somebody, somewhere, told that the condition FactionBuildingExists doesn't work, but I've been unable to find the post where it was told.

Can anybody confirm this point?

no problem having a lot of similar questions in same place would be better anyway

I don't know anything about that one, but I seem to have accidentally discovered trigger for Worldwide BuildingExists

monitor_event SettlementTurnEnd region_id=15
and I_CompareCounter Nagada = 1
and GarrisonSettlementRatio < 0.8
and SettlementBuildingExists > militia_barracks

using the region_id instead of settlement name is making it return > militia_barracks result for whole map

Underscores in internal names aren't the problem, it's spaces in external names.

Ah, thanks again, I think a lot of our place names are about to acquire ~ or - in that case!

[Makanyane]

Another question, sorry, could anyone give any general advice on efficiency when running a script? Is there any difference in game performance between having lots of separate monitor_events or a few larger ones with lots of if's?

I just managed to write a smallish script that made strat map grind to a halt - I'm hoping reason was I had a lot of

if I_CharacterTypeNearTile sarmatians general, 2 145,97
set_counter Roubair_slave 1
end_if

statements that weren't contained in monitors, which worked but must have meant it was checking them continuously
am trying to fix that at moment.

Am now getting things like:

monitor_event ButtonPressed ButtonPressed siege_assault_button
   and GarrisonSettlementRatio < 0.8

   if I_SettlementOwner Roubair = slave
         and I_FactionBesieged slave
         and I_FactionBesieging sarmatians
         and I_CompareCounter Roubair_slave < 1 
         and I_CompareCounter severin = 1 (that bit is local player check for sarmatians)

      if I_CharacterTypeNearTile sarmatians general, 2 145,97
         set_counter Roubair_slave 1
      end_if
      if I_CharacterTypeNearTile sarmatians family, 2 145,97
         set_counter Roubair_slave 1
      end_if

       if I_CompareCounter Roubair_slave = 1
         set_counter Roubair_slave 2
     	 console_command add_money slave, 1000
         console_command create_unit Roubair "west swordmen" 1
         console_command create_unit Roubair "west archers" 1
         console_command create_unit Roubair "west archers" 1
   	 console_command add_population Roubair  -300
         if RandomPercent < 40
         console_command create_unit Roubair "west swordmen" 1
   	 console_command add_population Roubair  -100
         end_if
         if RandomPercent < 40
         console_command create_unit Roubair "west archers" 1
   	 console_command add_population Roubair  -100
         end_if
      end_if
terminate_monitor
      end_if
end_monitor

which works but I'm not sure how efficient that is - does it make any difference what you put as the first part of the if? ie. if you put the thing least likely to occur at the top does it stop it checking through more of the map?

[Red Spot]

theoraticly I'd say that you're better of putting stuff in a single monitor with lots of if's, as long as whatever is in that monitor is similair stuff and you're not just calling that monitor for an entire script just cause someone said monitors are more demanding ... :D

the game needs to continually(sp?) check up on monitors, where the if-statements are only being processed once the monitor is actually triggered

(I dont think there is a single "black and white" answer here, just try not to spam monitors and keep things properly grouped)

those "if character near .... " commands I have 2*198 in a single monitor, but all that monitor does is check up on generals near a tile and spawm some men if wanted/needed, anything else is again in its own monitors


not too experianced scripting TW, but in other engines I always made sure that the if-statement least likelly to pass are checked first so there are as little follow-up checks as possible, though there will be little to even no diff. at all in how demanding a script is, at least not noticable, but every little bit helps specially if eventually your mod might be run by someone on a rather old system, or if you're using a zillion statements ... ;)


btw;
siege_assault_button, is that the "start siege on battlemap" button??
also GarrisonSettlementRatio < 0.8, does that work??
I've tried that one in M2 (or similair one) and it didnt "seem" to work there, does the current command basicly mean "if garrison is smaller than 80% of 20units" ??


this is the start of my garrison bit of my script, just Rome in the example;

monitor_event ScrollOpened seige_scroll
and ScrollOpened seige_scroll
	if not I_SettlementOwner Rome = romans_julii
		if I_CharacterTypeNearTile romans_julii family, 3 255, 155
			set_counter Settlement_Besieged 1
		end_if
		if I_CharacterTypeNearTile romans_julii general, 2 255, 155
			set_counter Settlement_Besieged 1
		end_if
		if I_CompareCounter Settlement_Besieged = 1
			if I_SettlementOwner Rome = romans_senate
				console_command create_unit Rome "roman praetorian cohort" 6 7 3 3
				console_command create_unit Rome "roman praetorian cavalry" 2 7 3 3
				console_command create_unit Rome "roman urban cohort" 4 6 3 3
				console_command create_unit Rome "roman legion archer ii" 4 5 3 3
			end_if
			if not I_SettlementOwner Rome = romans_senate
			and I_CompareCounter Settlement_Level = 3
				console_command create_unit Rome "roman urban cohort" 6 6 3 3
				console_command create_unit Rome "roman legion archer ii" 3 3 3 3
				console_command create_unit Rome "roman urban cohort" 4 5 3 3
				console_command create_unit Rome "roman legion archer ii" 3 4 3 3
			end_if
			if not I_SettlementOwner Rome = romans_senate
			and I_CompareCounter Settlement_Level < 3
				console_command create_unit Rome "roman legion cohort ii" 5 3 2 2
				console_command create_unit Rome "roman legion archer ii" 3 2 2 2
				console_command create_unit Rome "roman legion cohort ii" 5 4 2 2
				console_command create_unit Rome "roman legion archer ii" 3 3 2 2
			end_if
			set_counter Settlement_Besieged 0
		end_if
	end_if
end_monitor

G

[Atilius]

Guess this is good lesson not to use underscored internal names.

Underscores in internal names aren't the problem, it's spaces in external names.