Not quite right.
1. JHI have light spear bonusses on their halberd, so are +4 vs cavalry and usually very effective against them too unless they are being charged. Dismounted landers have a +8 bonus and shields, so tend to hold up better against a unit that attempts to move through them.
2. General's units slowly recover over time and cannot be retraniend unless you mod that in. Upgrading them does not add extra units, just the upgrades themselves. The downside of their recovery feature is that the newly added bodyguards are added at the lowest experience level (0) and thus overall drag their experience count down, contrary to normally retrained units which keep their experience bonus or get a +1 rarely.
Bookmarks