Pyrrhus was a good general but theres a reason that its called a Pyrrhic victory!

And I agree totally with Quirinus, Sulla and Mithradates the Great were both fascinating! But I read the question as being who was the best (ie most successful) general!