I usually assault, if not on the 2nd turn of the siege then almost certainly later. The reason being that for most cities the general leading the siege will acquire the "starving" trait giving -3 morale before the enemy sallies. I don't think it would matter so much, but the AI doesn't seem to get any supply traits, and I don't want them to have so much more morale than me.