AgentType priest vs heretic

[FactionHeir]

I'm just curious, are heretics considered priests as well by the game?

Reason is that in our PBM, a priest turned heretic would have the NaturalPriestSkill still. I then made a fix for that:

Trigger hereticinit1_naturalclear
    WhenToTest PriestBecomesHeretic

    Condition Trait NaturalPriestSkill > 0

    Affects NaturalPriestSkill -3  Chance  100

But for some reason in my test game, priests turned heretic still seem to be getting the NaturalPriestSkill.

The trigger for the trait itself only specifies Condition AgentType priest.

Unless I missed something (which is unlikely because I checked every trigger for NaturalPriestSkill), I guess heretics are considered priests also by the game.

I think I'll have to amend following code to

Trigger priestinit1
    WhenToTest AgentCreated

    Condition AgentType = priest
            and not AgentType = heretic

    Affects NaturalPriestSkill  1  Chance  100

Comments?

[alpaca]

The problem could be that the traits aren't cleaned by game hardcode when the character turns heretic, and that the NaturalPriestSkill is only available to priest characters, so you probably couldn't lower it again.
Changing the trigger would have no effect on this behaviour if that theory is true.

A possible workaround would be to make the trait available for all characters and differentiate in triggers, in which case your cleaning trigger should start functioning.

[FactionHeir]

Some priest traits were actually cleaned when a priest turns heretic by default in the character_trait file, but I merely expanded on the number of traits cleaned (as it wouldn't make much sense to have say a bishop heretic or a guildmember heretic) including naturalpriestskill, which somehow seems to be the only trait having a problem thus far (and its the only trait given on creation of any priest agent type)

[FactionHeir]

After extensive testing, setting NaturalPriestSkill to priest and heretic and giving out the trait to priests but not heretics solved the issue.

[alpaca]

After extensive testing, setting NaturalPriestSkill to priest and heretic and giving out the trait to priests but not heretics solved the issue.

You still have your cleaning trigger in, though, don't you?
Or does it work out of the box?

[FactionHeir]

I got my cleaning trigger still in, yes.
CA only cleaned 2 traits from priests turning heretic and they even had the same trigger name, which would cause some issues. I have triggers to clean every trait except BadDenouncer, Dogmatic, OpenMinded and SecretlyFemale.