1.2 (preliminary) trait and ancillary 'issues'

[FactionHeir]

I've just finished my tweaking of the character trait and ancillary files and would like to list the issues I've come across so that fellow modders working with 1.2 can quickly and readily pinpoint issues they want to tackle. Feel free to add to this list:

;------------------------------------------
Trigger sitting_around_town_with_city_barracks
    WhenToTest CharacterTurnEnd

    Condition IsGeneral
          and EndedInSettlement
          and RemainingMPPercentage = 100
          and SettlementBuildingExists >= library

    Affects StrategicSkill  1  Chance  4
;-------------------------------------------

This code obviously has been copied incorrectly somewhere. It should read
SettlementBuildingExists >= militia_drill_square

The trigger for dads_prim is duplicated as dads_prim and dads_Prim

dads_smoothtalker trigger exists even though the trait is diplomat only

Further improper trait triggers:
SmoothTalker in random_birth12
dads_SmoothTalker
GoodConspirator in random_birth27
Secretive in random_birth31
Talkative in random_birth34

Hate traits' 2nd level randomly gives morale or not. Similarly 3rd level randomly decreases morale or not.

birth_with_sanitation, academia, alchemy, religious all lack > at >=

Trigger governing9 is senseless as far as I can tell in context.

assassininit7 should be SettlementBuildingExists

CA has added some extra trait clearers when priests turn heretic, but still lacking the clearance of TheologiansGuildMember, TheologiansGuildTrained, NaturalPriestSkill, PriestLevel.

handgun ancillary still gives +2 law.

armour_custom ancillary only triggered by armourer but not by levels above when sitting around town.

marco polo ancillary still given to everyone instead of Generals only.

assassininit11 gives handgun if gunsmith present but lacks trigger for c_gunsmith as some factions can train assassins in castles

Description errors:
RansomChivalry description (incorrectly identical to CaptorChivalry)
Nuerotic (trait level is called Nuerotic and trait display as well - should be Neurotic)
LenientJustice at level Way_too_leniant (should be lenient)


Note I'm only calling those 'issues' or 'problems' as we cannot be certain they are 'bugs' without CA feeling they are.