Nope they never attack you.
The only problem is that if they are allied to someone you want to declare war on, they might break their alliance with you and thus end the vassalship.